Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Feedback! #3

Open
codepathreview opened this issue Oct 2, 2021 · 1 comment
Open

Project Feedback! #3

codepathreview opened this issue Oct 2, 2021 · 1 comment

Comments

@codepathreview
Copy link
Collaborator

It looks like the following features are not reflected on your GIF walkthrough:

  • Allow video posts to be played in full-screen using the YouTubePlayerView.

In order for us to count these towards your submission, please record another GIF that captures these features. Once you do, please push your updates and submit your assignment again through the course portal within 48 hours from the posted deadline so that we can regrade it.

@artballesteros
Copy link
Owner

artballesteros commented Oct 2, 2021

Just to clarify, should a video be automatically set to full-screen once I play the video or even when the video is only loaded? As I understand it, the video should play automatically at full screen when it is rated with more than five stars. Otherwise, the video isn't set to full screen nor played automatically.
Thanks!

EDIT: I reread and realized that I was overthinking it. I will post a GIF showing the videos manually set to full-screen as they are played.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants