Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle multiple unused submodule imports #60

Open
charliermarsh opened this issue Aug 31, 2022 · 3 comments · May be fixed by #13965
Open

Handle multiple unused submodule imports #60

charliermarsh opened this issue Aug 31, 2022 · 3 comments · May be fixed by #13965
Labels
bug Something isn't working

Comments

@charliermarsh
Copy link
Member

pylint does this properly, Flake8 does not.

For example, with this:

import multiprocessing.pool
import multiprocessing.process

Flake8 will only mark the second import as unused.
@charliermarsh charliermarsh added the bug Something isn't working label Aug 31, 2022
@squiddy
Copy link
Contributor

squiddy commented Nov 9, 2022 •
edited
Loading

I have a question concerning a slightly adjusted example.

import multiprocessing.pool
import multiprocessing.process

z = multiprocessing.pool.ThreadPool()

pylint and flake8 don't see any unused import here. I would argue import multiprocessing.process is.

Update Working on this, PR incoming.

@squiddy squiddy mentioned this issue Nov 10, 2022
Closed
1 task
@shiftinv shiftinv mentioned this issue Mar 30, 2023
Open
This was referenced Jun 10, 2023
Open
Closed
Closed
MichaReiser added a commit that referenced this issue Jul 27, 2023
@MichaReiser
Merge pull request #60 from astral-sh/reduce-copy
33a3c40
@charliermarsh charliermarsh mentioned this issue Oct 16, 2023
Closed
@charliermarsh charliermarsh mentioned this issue Nov 14, 2023
Closed
@ThiefMaster
Copy link
Contributor

Would you consider exempting F401 from RUF100 until this is solved?

Even if ruff cannot handle this correctly, it'd be much cleaner if as a developer one could still add the proper noqa on each such unused import simply to indicate to other developers that they are aware of it being unused.

@ThiefMaster ThiefMaster mentioned this issue Nov 14, 2023
Open
@charliermarsh charliermarsh mentioned this issue Mar 30, 2024
Closed
@JonathanPlasse
Copy link
Contributor

Will Red knot address this issue?

@dhruvmanila dhruvmanila mentioned this issue Aug 20, 2024
Open
@gpilikin gpilikin linked a pull request Oct 28, 2024 that will close this issue
Open
@MichaReiser MichaReiser mentioned this issue Nov 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
4 participants
@squiddy @ThiefMaster @charliermarsh @JonathanPlasse