-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new configurationPreference
value filesystemOnly
#16209
Comments
We'd need to be careful around versioning as this would be added in Ruff and the VS Code extension but if there's a mismatch between the version the extension shouldn't error. |
I think it is editor-related feature and already could be handled by VSCode: reset modified settings per workspace/folder. Also, IMO, ruff.configurationPreference setting could have only two varients: Since the preference word points to selecting one among others, I think it makes more sense to NOT having |
Can you say more about this? What's "VSCode: reset modified settings"? I think the user still wants to keep the settings but not use it, it does seem counterintuitive to still keep them. |
Reading the issue description. I don't think I do agree with @T-256 that I don't think a Maybe it's just a naming issue, but I get the impression that
That makes me wonder if we should have a dedicated settings instead. A related option -- that I'm surprised it has never come up before -- is whether Ruff should run on projects that don't have a project configuration. I don't think we have to solve this here, but maybe something to keep in mind. |
@MichaReiser Currently Instead, a fifth option with the meaning "use |
I still see an opportunity to error correct. We have to support Either way, I don't think a |
(I'm going to mark this as "needs-decision" as after talking with Micha I agree that we can improve here.) |
You can keep them as User settings and overriding them to default values in Workspace settings.
Then only filesystem configs are respected. |
That's a good suggestion, thanks. @VictorGillioz does this help your use-case? |
Description
Originally posted by @VictorGillioz in #425
The text was updated successfully, but these errors were encountered: