feat: allow optional injection of custom Pinecone client #529
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a new `client` parameter to `PineconeIndex.__init__` for dependency injection. - Use the supplied client if provided, otherwise initialize a new Pinecone client. - Maintain backward compatibility while improving testability and configuration flexibility. - removing duplication on api_key Fixes aurelio-labs#525
|
thanks for the pr @clioo — I see issues in the lint, are you able to take a look? The linter can be run locally with The test failure potentially looks like it is due to api keys — I'll test locally once linting is resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clientparameter toPineconeIndex.__init__for dependency injection.Fixes #525