Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production ready? #15

Open
rohmann opened this issue Feb 9, 2016 · 7 comments
Open

Production ready? #15

rohmann opened this issue Feb 9, 2016 · 7 comments
Labels

Comments

@rohmann
Copy link

rohmann commented Feb 9, 2016

Love where you're going with this.

Would you say this is more experimental? Or is there confidence in it being production ready?

@ausi ausi added the question label Feb 10, 2016
@ausi
Copy link
Owner

ausi commented Feb 10, 2016

One of its goals is definitely to be production ready, but since it didn’t reach version 1.0 yet, there may be breaking changes in the future, see #8 for example.

If you want to use it in production you should use the PostCSS plugin and check your CORS settings to get the best performance.

@rohmann
Copy link
Author

rohmann commented Feb 10, 2016

Thank you sir! That really helps. It's certainly tempting even with the risk of things changing. I'll play around with it. Looking forward to see where things go with this project.

@rask
Copy link

rask commented Feb 10, 2016

I've been using this in a few projects just fine. Just had to create a Sass function for parsing the container query rules.

@rohmann
Copy link
Author

rohmann commented Feb 12, 2016

@rask Awesome, thanks for chiming in to confirm. So would your Sass function be an alternative to the PostCSS plugin then?

@rask
Copy link

rask commented Feb 12, 2016

@rohmann Kind of yeah, I'm using just the prolyfill and running the Sass function to parse the classnames for the Sass->CSS conversion (instead of Sass->CSS->PostCSS). I made a Gist to show how I did it: https://gist.github.com/rask/434e96f603e8b439dc64

That function may need updating later on in case the syntax changes. I needed that for simple width/height defined container queries so there may be cases it doesn't work right.

@rohmann
Copy link
Author

rohmann commented Feb 15, 2016

Nice! Thanks for sharing that :)

@rask
Copy link

rask commented Feb 16, 2016

@rohmann: @ausi made a pure mixin-based version of that function so you might want to check it out too: #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants