Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pagination convention to use a gem with a better benchmark #24

Open
ErvalhouS opened this issue Nov 16, 2018 · 1 comment
Open
Labels
enhancement New feature or request help wanted Extra attention is needed performance Performance related issues or pull requests

Comments

@ErvalhouS
Copy link
Contributor

Performance will always be an issue when it comes to APIs.

With that in mind the project should adapt to the ever changing nature of web development and it's conventions.

Suggestion here is to refactor the pagination feature to use a gem with better benchmarks: Pagy

@ErvalhouS ErvalhouS added enhancement New feature or request help wanted Extra attention is needed performance Performance related issues or pull requests labels Nov 16, 2018
@ErvalhouS
Copy link
Contributor Author

Better yet would be to have a configuration option where you choose which library to use pagination from. Options would be: :will_paginate, :kaminari or :pagy. This way it would enable to existing project to avoid having an extra dependency if any of those gems are already in use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed performance Performance related issues or pull requests
Projects
None yet
Development

No branches or pull requests

1 participant