Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent dependencies for ‎AWSSDK.Extensions.NETCore.Setup #3598

Open
1 task
rsking opened this issue Jan 8, 2025 · 1 comment
Open
1 task

Inconsistent dependencies for ‎AWSSDK.Extensions.NETCore.Setup #3598

rsking opened this issue Jan 8, 2025 · 1 comment
Labels
bug This issue is a bug. Extensions p2 This is a standard priority issue v4 xs Effort estimation: tiny

Comments

@rsking
Copy link

rsking commented Jan 8, 2025

Describe the bug

as per 6215931 which updates Microsoft.Extensions.DependencyInjection.Abstractions for .NET 8.0+, but this does not also update https://github.com/aws/aws-sdk-net/blob/v4-development/extensions/src/AWSSDK.Extensions.NETCore.Setup/AWSSDK.Extensions.NETCore.Setup.nuspec#L31

Regression Issue

  • Select this option if this issue appears to be a regression.

Expected Behavior

The dependencies are consistent between the two files.

Current Behavior

nuget reports version 2.0, whereas the assembly requires 8.0

Reproduction Steps

  1. Have an assembly that has a reference to Microsoft.Extensions.DependencyInjection.Abstractions < 8.0
  2. Add a reference to AWSSDK.Extensions.NETCore.Setup v4.0.0-preview.5
  3. dotnet build

This should fail due to the assembly having a reference to Microsoft.Extensions.DependencyInjection.Abstractions < 8.0, whereas the assembly AWSSDK.Extensions.NETCore.Setup requires >= 8.0

Possible Solution

update <dependency id="Microsoft.Extensions.DependencyInjection.Abstractions" version="2.0.0" /> to <dependency id="Microsoft.Extensions.DependencyInjection.Abstractions" version="8.0.0" />

Additional Information/Context

No response

AWS .NET SDK and/or Package version used

AWSSDK.Extensions.NETCore.Setup 4.0.0-preview.5

Targeted .NET Platform

.NET 8.0, .NET 9.0

Operating System and version

Windows 11

@rsking rsking added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jan 8, 2025
@eddiemcs3 eddiemcs3 added the v4 label Jan 9, 2025
@ashishdhingra ashishdhingra self-assigned this Jan 9, 2025
@ashishdhingra ashishdhingra added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Jan 9, 2025
@ashishdhingra
Copy link
Contributor

@rsking Thanks for the PR contribution. nuspec file should be in sync with .csproj.

@ashishdhingra ashishdhingra added p2 This is a standard priority issue xs Effort estimation: tiny and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Jan 9, 2025
@ashishdhingra ashishdhingra removed their assignment Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. Extensions p2 This is a standard priority issue v4 xs Effort estimation: tiny
Projects
None yet
Development

No branches or pull requests

3 participants