RefreshingAWSCredentials ShouldUpdateState() call to IsExpiredWithin() uses TimeSpan.Zero instead of PreemptExpiryTime

[StevenKehrli]

Describe the bug

Found in commit 17334e8

RefreshingAWSCredentials calls ShouldUpdateState() on multiple paths (GetCredentials(), GetCredentialsAsync(), and UpdateToGeneratedCredentials() methods; ShouldUpdate property) with the PreemptyExpiryTime property.

However, the ShouldUpdateState() method ignores the value of the preemptExpiryTime parameter and uses TimeSpan.Zero instead. This means we will not try to update the credentials until they have already expired. (In the case of AssumeRoleAWSCredentials, the PreemptExpiryTime is 15 minutes; so 15 minutes before the expiration time.)

aws-sdk-net/sdk/src/Core/Amazon.Runtime/Credentials/RefreshingAWSCredentials.cs

Line 240 in 17334e8

var isExpired = state?.IsExpiredWithin(TimeSpan.Zero);

Regression Issue

• Select this option if this issue appears to be a regression.

Expected Behavior

ShouldUpdateState() uses its preemptExpiryTIme parameter, so credentials are updated before they are expired.

Current Behavior

ShouldUpdateState() effectively ignored the preemptyExpiryTime, so credentials are not updated until already expired.

Reproduction Steps

Read the description.

Possible Solution

Change the below line to use the preemptExpiryTime parameter instead of TimeSpan.Zero.

Additional Information/Context

No response

AWS .NET SDK and/or Package version used

AWSSDK.Core 3.7.401.2

Targeted .NET Platform

not relevant - but .NET 9

Operating System and version

not relevant - but macOS Sequoia 15.2

[ashishdhingra]

@StevenKehrli Good morning. Thanks for opening the issue. I'm unsure what you found in commit 17334e8 which is related to the issue, but looking at code for ShouldUpdateState(CredentialsRefreshState state, TimeSpan preemptExpiryTime) doesn't appear to make use of preemptExpiryTime parameter. This method was added as part of refactoring done in commit 4c8d84b back in 2019. This needs review with the team on why preemptExpiryTime parameter is not used, it could be a miss.