Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor module to separate implementations #13

Open
jboynes opened this issue Jun 7, 2018 · 1 comment
Open

Refactor module to separate implementations #13

jboynes opened this issue Jun 7, 2018 · 1 comment

Comments

@jboynes
Copy link
Contributor

jboynes commented Jun 7, 2018 •
edited
Loading

There are two metric-related modules at the moment: metrics-api and metrics-core.
Some things in core might be worth moving to the API e.g. ScopedMetrics and Timer

Core contains recorder implementations for 'file' and 'cloudwatch' - these could be moved to separate modules to control dependencies. If that is done, do we still need 'core'?

Should the JMX integration be moved to its own module?
@dainstber
Copy link
Contributor

While doing this we should split the JMX sensors out of core package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jboynes @dainstber