Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Bug in bkT dyncov LL #111

Open
pschil opened this issue Jun 18, 2020 · 0 comments
Open

Minor Bug in bkT dyncov LL #111

pschil opened this issue Jun 18, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@pschil
Copy link
Collaborator

pschil commented Jun 18, 2020

While introducing tests against the dyncov LL in #110 it was found that not all tests as described in #98 hold.

bkT=T*C is not true for gamma=0:
Instead of 38 (Tcal) it yields 37.85714. This likely is because something slipped by a day (ie 0.15 is 1/7 of a weekly period).

The final LL values are still equal to the nocov LL values and therefore the test was commented out and the LL left as is.

@pschil pschil added the bug Something isn't working label Jun 18, 2020
@mmeierer mmeierer added this to the v1.0 milestone Jun 23, 2020
@mmeierer mmeierer modified the milestones: v1.0, v0.7 Jun 23, 2020
@mmeierer mmeierer modified the milestones: v0.7, v0.8 Jul 24, 2020
@mmeierer mmeierer removed this from the v0.9 milestone Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants