Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If not license specified Mock-Build fails silently #56

Open
tommrr opened this issue Aug 29, 2018 · 3 comments
Open

If not license specified Mock-Build fails silently #56

tommrr opened this issue Aug 29, 2018 · 3 comments

Comments

@tommrr
Copy link

tommrr commented Aug 29, 2018

If the project.json is missing the license tag then when running mock build on the generated spec from Speculate, will silently fail with no error.

@niklasR
Copy link
Contributor

niklasR commented Aug 29, 2018

Happy to take a PR.
(Though I'd recommend to set { "license": "UNLICENSED" } or something and be explicit about it if you don't have a licence, rather than omitting the key)

@owenj62
Copy link

owenj62 commented Mar 7, 2019

I've also just spent a day debugging this issue

@njh
Copy link
Member

njh commented May 29, 2019

If created a PR that throws an error much earlier in the process, would that make things better?

Maybe with a error message saying "please set license to 'UNLICENSED'" if this is not Open Source software.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants