Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigation: How much will revision-comparison-generation-speed affect user experience? Are there mitigations? #546

Open
david-fong-bc opened this issue Oct 1, 2024 · 0 comments
Assignees
Labels
investigation question Further information is requested

Comments

@david-fong-bc
Copy link

david-fong-bc commented Oct 1, 2024

Observation: after importing a data dictionary with 1000 items into a MR, comparing consecutive revisions (where each consecutive pair has more items due to batched data dictionary item upload) gets slower with each later pair of revisions, until the gateway times out. This can be reproduced by opening https://dev.cat.data.fin.gov.bc.ca/node/157/revisions/view/11152/11154/visual_inline and continually clicking "Next change". I'm guessing that computing the diff is getting more expensive as there is more content to compare.

Nicole let me know that the T1 tax form has many fields (~800), which was why importing 1000 rows was tested. I am curious how much / how severely this will affect users, and whether there's anything that can be done to make it better. Getting some info on roughly how much computer memory and CPU these operations are using might be a good place to start.

For investigation: Does this happen when comparing two very similar, published revisions after auto-pruning has run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigation question Further information is requested
Projects
Development

No branches or pull requests

3 participants