Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geckolib animations issue #682

Closed
KateFaber opened this issue Feb 23, 2025 · 16 comments
Closed

Geckolib animations issue #682

KateFaber opened this issue Feb 23, 2025 · 16 comments

Comments

@KateFaber
Copy link

KateFaber commented Feb 23, 2025

Hi, I know it's an old bug and I thought it was fixed in the latest Geckolib versions ( thats why i moved from 1.18 to 1.20 MC) But in some cases animations are still not playing when using shaders. I guess it depends on the direction of the light and shadows :(
(example: Unicorn from DragN's Livestock Overhaul)
geckolib-forge-1.20.1-4.7

Gecko.animation.bug0.mp4.mp4
@Tslat
Copy link
Collaborator

Tslat commented Feb 24, 2025

Show your modlist

@KateFaber
Copy link
Author

sure

Image

@KateFaber
Copy link
Author

But I don't think it's caused by another mod. I tested it by removing almost all mods, but the problem remains.

Image

Gecko.animation.bug1.mp4

@Tslat
Copy link
Collaborator

Tslat commented Feb 24, 2025

Does this only happen to the unicorns? or other things too?

This definitely was fixed, so it's interesting

@KateFaber
Copy link
Author

KateFaber commented Feb 24, 2025

Unicorns, llamas, rabits have animation bug. Horses, mules , cows, pigs, goats, sheeps, oxes, camels and caribou seem to be good,. But others have animation issues which can only be fixed by disabling entity shadows. I think it depends on the direction of the light, when they move in the other direction animation can start working properly, but later it's buggy again.

@KateFaber
Copy link
Author

like this

rabbit.animation.bug.mp4

@Tslat
Copy link
Collaborator

Tslat commented Feb 25, 2025

What interests me here is that the idle animation works perfectly fine, it's the walk animation specifically that doesn't

That leads me to believe it's not an animation issue generally, but specifically with moving.

Are all these entities from the same mod?

@KateFaber
Copy link
Author

yes, from DragN's Livestock Overhaul

@Tslat
Copy link
Collaborator

Tslat commented Feb 25, 2025

Yeah this looks like a them problem

Image

They're doing some sort off weird calculation for their movement check

@KateFaber
Copy link
Author

Is there any way to fix it?
The author claims he can't fix the animation problems on his end :(

@Tslat
Copy link
Collaborator

Tslat commented Feb 25, 2025

I mean I can't fix their code

I haven't seen anything here that indicated that this is GeckoLib's issue

The animations are working perfectly fine, as evidenced by the video. The issue here is their predication of whether it should be moving or not, which is their code, not GeckoLib's

Have a look while the entity is moving - it's still playing the idle animation. Their code to check if the entity is moving is failing.

@Tslat Tslat closed this as not planned Won't fix, can't repro, duplicate, stale Feb 25, 2025
@KateFaber
Copy link
Author

KateFaber commented Feb 25, 2025

Idle animations were working on 1.18 mc too, but movement animation were buggy. For example from Critters and Companions on 1.18.2 vers. Another strange thing was that all the entities nearby copied the state of the main entity that was load first. i.e. if the main ferret is sitting, all the others also froze in the same position ( on the video) And now it's the same bug but only with few entities on 1.20.1 from DragN's Livestock Overhaul.

animation.bug.1.18.2.mp4

@Tslat
Copy link
Collaborator

Tslat commented Feb 26, 2025

Yes, which is the bug that was fixed in newer versions

The issue you've shown me so far is a completely different one however

@KateFaber
Copy link
Author

KateFaber commented Feb 26, 2025

well, these entities have this issue too on 1.20.1 >_<
and only without shadows it works fine

animation.bug.3.mp4

@Tslat
Copy link
Collaborator

Tslat commented Feb 26, 2025

Does it happen with entities from any other mod?

@KateFaber
Copy link
Author

No, I didn't see that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants