Skip to content

Commit

Permalink
Use our own names for the ITCSS layers
Browse files Browse the repository at this point in the history
  • Loading branch information
katrinundfritz committed Oct 5, 2022
1 parent 0565b32 commit 4a57eed
Show file tree
Hide file tree
Showing 10 changed files with 11 additions and 22 deletions.
3 changes: 1 addition & 2 deletions .storybook/order.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,9 @@
["About the Design System", "Design Principles", "Experience Values"],
"Guides",
["Content Guide", "Accessibility Guide", "UX Design Guide", "Development Guide", "Testing Guide"],
"Design Tokens (Settings)",
"Tokens",
["Introduction", "Colors", "Typography", "Spacing", "Grid", "Breakpoints"],
"Elements",
"Objects",
"Components",
"Hooks"
]
2 changes: 1 addition & 1 deletion src/stories/design_tokens/breakpoints.stories.mdx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Meta } from '@storybook/addon-docs'

<Meta title="Design Tokens (Settings)/Breakpoints" />
<Meta title="Tokens/Breakpoints" />

# Breakpoints

Expand Down
2 changes: 1 addition & 1 deletion src/stories/design_tokens/colors.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import themeTokens from '../../../build/json/themes/org.json'
import globalTokens from '../../../build/json/globals.json'

export default {
title: 'Design Tokens (Settings)/Colors',
title: 'Tokens/Colors',
} as ComponentMeta<typeof ColorSwatch>

type ColorSwatchProps = {
Expand Down
2 changes: 1 addition & 1 deletion src/stories/design_tokens/grid.stories.mdx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Meta } from '@storybook/addon-docs'

<Meta title="Design Tokens (Settings)/Grid" />
<Meta title="Tokens/Grid" />

# Grid

Expand Down
2 changes: 1 addition & 1 deletion src/stories/design_tokens/introduction.stories.mdx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Meta } from '@storybook/addon-docs'

<Meta title="Design Tokens (Settings)/Introduction" />
<Meta title="Tokens/Introduction" />

# Introduction

Expand Down
2 changes: 1 addition & 1 deletion src/stories/design_tokens/spacing.stories.mdx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Meta } from '@storybook/addon-docs'

<Meta title="Design Tokens (Settings)/Spacing" />
<Meta title="Tokens/Spacing" />

# Spacing

Expand Down
2 changes: 1 addition & 1 deletion src/stories/design_tokens/typography.stories.mdx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Meta } from '@storybook/addon-docs'

<Meta title="Design Tokens (Settings)/Typography" />
<Meta title="Tokens/Typography" />

# Typography

Expand Down
2 changes: 1 addition & 1 deletion src/stories/design_tokens/ui.stories.mdx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Meta } from '@storybook/addon-docs'

<Meta title="Design Tokens (Settings)/UI" />
<Meta title="Tokens/UI" />

# UI (🚧 Find a better name)

Expand Down
6 changes: 3 additions & 3 deletions src/stories/guides/engineering_guide.stories.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ rules: [From general to specific](https://en.wikipedia.org/wiki/Hierarchy#Contai

Here is, **in our own words**, and applied to our specific context, what each of these layers is about:

#### 1. Settings
#### 1. Settings (We call it Tokens.)

In ITCSS _settings_ constitute the first layer.
It’s the most general layer and the one with the widest reach.
Expand All @@ -57,7 +57,7 @@ certain properties of the design. At _Salesforce_ they
(a. k. a. CSS variables) and, if needed, as preprocessor variables.
- For a reasonable implementation example of this layer see [Pollen](https://www.pollen.style/).

#### 2. Tools
#### 2. Tools (We call it Mixins.)

- Globally used mix-ins and functions for CSS preprocessors.
- Using PostCSS, these will probably be implemented as @apply blocks.
Expand All @@ -78,7 +78,7 @@ It’s reserved for bare HTML elements.
[the HTML elements reference at MDN](https://developer.mozilla.org/en-US/docs/Web/HTML/Element)
(which is also the knowledge base [recommended by the W3C](https://www.w3.org/wiki/Open_Web_Platform#HTML_Elements)).

#### 5. Objects
#### 5. Objects (We call them Coponents. So we don't differentiate between Objects and Components.)

- Common design patterns as described by [OOCSS](https://www.smashingmagazine.com/2011/12/an-introduction-to-object-oriented-css-oocss/)
- Normally represented by assigning a single classname.
Expand Down
10 changes: 0 additions & 10 deletions src/stories/objects/introduction.stories.mdx

This file was deleted.

0 comments on commit 4a57eed

Please sign in to comment.