Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make design of improved stylesheet #990

Open
teusbenschop opened this issue Dec 15, 2024 · 0 comments
Open

Make design of improved stylesheet #990

teusbenschop opened this issue Dec 15, 2024 · 0 comments
Assignees
@teusbenschop
Labels
enhancement

Comments

@teusbenschop
Copy link
Member

teusbenschop commented Dec 15, 2024 •
edited
Loading

Think about and design a way forward for having a more typed stylesheet.

The types can use enums.
The types can use inheritance too.
The types may be hard coded in the software.
The styling may be hard coded in the software.
Overrides of markers and styling perhaps should be possible if not too hard.
And so on....

A possible outcome may be that the current system is good and only needs extensions.
Or that the current system needs a complete overhaul.
Or ...
@teusbenschop teusbenschop self-assigned this Jan 3, 2025
teusbenschop added a commit that referenced this issue Jan 4, 2025
@teusbenschop
Add std::list to the default includes
3edf7fa 
#990
teusbenschop added a commit that referenced this issue Jan 4, 2025
@teusbenschop
Initiate styles version 2
1991974 
1. Ideas.
2. Design.
#990
teusbenschop added a commit that referenced this issue Jan 4, 2025
@teusbenschop
Cosmetic stuff
fbb91d4 
#990
teusbenschop added a commit that referenced this issue Jan 5, 2025
@teusbenschop
Updates and dev comment
9fdd9c8 
#990
teusbenschop added a commit that referenced this issue Jan 23, 2025
@teusbenschop
Remove dead link
e2e23f3 
#990
teusbenschop added a commit that referenced this issue Jan 24, 2025
@teusbenschop
More modern method to generate content of styles editor
c8cf877 
#990
teusbenschop added a commit that referenced this issue Jan 24, 2025
@teusbenschop
Re-indent
54d1d9c 
#990
teusbenschop added a commit that referenced this issue Jan 24, 2025
@teusbenschop
Modernize code
41cd01a 
#990
teusbenschop added a commit that referenced this issue Jan 24, 2025
@teusbenschop
Put function in namespace
1c8a389 
Function to create the styles database has been removed from the class instance and was put in a namespace.
#990
teusbenschop added a commit that referenced this issue Jan 24, 2025
@teusbenschop
Update namespace
3786fe6 
#990
teusbenschop added a commit that referenced this issue Jan 25, 2025
@teusbenschop
Put style in namespace
703fce7 
#990
teusbenschop added a commit that referenced this issue Jan 25, 2025
@teusbenschop
Modernize code
60e69ac 
#990
teusbenschop added a commit that referenced this issue Jan 25, 2025
@teusbenschop
Move class method to namespace function
a131b97 
#990
teusbenschop added a commit that referenced this issue Jan 25, 2025
@teusbenschop
Modernize code etc.
42d4b3d 
#990
teusbenschop added a commit that referenced this issue Jan 25, 2025
@teusbenschop
Modernize code
20e27df 
#990
Prepare for adding and deleting markers for styles version 2.
teusbenschop added a commit that referenced this issue Jan 25, 2025
@teusbenschop
Get styles v1 and v2 modern code
132675d 
#990
teusbenschop added a commit that referenced this issue Jan 25, 2025
@teusbenschop
Work towards styles v2
bf0ebd8 
More modern v1 code.
Getting markers in v2 empty function created.
#990
teusbenschop added a commit that referenced this issue Jan 26, 2025
@teusbenschop
Use namespaces / function for styles v2
0ef8654 
#990
teusbenschop added a commit that referenced this issue Jan 26, 2025
@teusbenschop
Move functions from class to namespace
b5e63f6 
#990
teusbenschop added a commit that referenced this issue Jan 26, 2025
@teusbenschop
Namespace update
80e5fef 
#990
teusbenschop added a commit that referenced this issue Jan 26, 2025
@teusbenschop
Remove empty class
a323064 
#990
teusbenschop added a commit that referenced this issue Jan 26, 2025
@teusbenschop
Better encapsulation in namespace
199de60 
#990
teusbenschop added a commit that referenced this issue Jan 29, 2025
@teusbenschop
Split existing unit tests in smaller ones
fa92f70 
#990
teusbenschop added a commit that referenced this issue Jan 29, 2025
@teusbenschop
Add unit test for styles v2
6ddde3e 
Test function get_styles();

This now gets "id" only, but will be expanded later.

Check some properties of "id".

#990
teusbenschop added a commit that referenced this issue Jan 31, 2025
@teusbenschop
Several styles v2 supportiing functions
a6c41ef 
#990
teusbenschop added a commit that referenced this issue Feb 2, 2025
@teusbenschop
Save / load styles v2
de3199a 
Functions for saving a style, and loading a style, now work.
Unit tests were added.
#990
teusbenschop added a commit that referenced this issue Feb 2, 2025
@teusbenschop
Functions to get styles
d8f98a6 
Functions to get styles and markers were updated. Testing was added.
#990
teusbenschop added a commit that referenced this issue Feb 13, 2025
@teusbenschop
Move marker "ide" from v1 to v2
2bac708 
#990
teusbenschop added a commit that referenced this issue Feb 13, 2025
@teusbenschop
Style "rem" moved from v1 to v2
8ff0df0 
#990
teusbenschop added a commit that referenced this issue Feb 13, 2025
@teusbenschop
Markup for next styles to move to v2
0764f40 
#990
teusbenschop added a commit that referenced this issue Feb 13, 2025
@teusbenschop
Rename operation
a77789e 
#990
teusbenschop added a commit that referenced this issue Feb 16, 2025
@teusbenschop
Move markers h h1 h2 h3 to styles v2
1f0c0c9 
#990
teusbenschop added a commit that referenced this issue Feb 16, 2025
@teusbenschop
Style "toc1" moved to v2
bd82f96 
#990
teusbenschop added a commit that referenced this issue Feb 16, 2025
@teusbenschop
Move "toc2" to styles v2
be87a75 
#990
teusbenschop added a commit that referenced this issue Feb 16, 2025
@teusbenschop
Cleanup
c25c380 
#990
teusbenschop added a commit that referenced this issue Feb 17, 2025
@teusbenschop
Move "toc3" and "cl" to styles v2
f3a84cf 
#990
teusbenschop added a commit that referenced this issue Feb 18, 2025
@teusbenschop
Move marker to v2 and remove unused marker from v1
5587cda 
#990
teusbenschop added a commit that referenced this issue Feb 19, 2025
@teusbenschop
Unit tests for all markers to get ecitor action
e4aef38 
Since the styles are being moved to v2, and the editor actions are so important, to catch regressions during move from v1 to v2, all possible markers were tested here.
#990
teusbenschop added a commit that referenced this issue Feb 19, 2025
@teusbenschop
Move marker "vp" to styles v2
cddaf32 
#990
teusbenschop added a commit that referenced this issue Feb 19, 2025
@teusbenschop
Improvements and adding removed info just now
86578d1 
#990
teusbenschop added a commit that referenced this issue Feb 20, 2025
@teusbenschop
Add documentation llinks to styles v2
37e161b 
#990
teusbenschop added a commit that referenced this issue Feb 21, 2025
@teusbenschop
Cleanup some code
2a370af 
#990
teusbenschop added a commit that referenced this issue Feb 21, 2025
@teusbenschop
Version bump
dabb998 
#990
teusbenschop added a commit that referenced this issue Feb 21, 2025
@teusbenschop
Better support for \ca in the visual editors
012e2ae 
#990
teusbenschop added a commit that referenced this issue Feb 21, 2025
@teusbenschop
Modernized converters, support for export \ca markup
8d9cae9 
#990
teusbenschop added a commit that referenced this issue Feb 22, 2025
@teusbenschop
Support for \ie
6938a9a 
#990
teusbenschop added a commit that referenced this issue Feb 22, 2025
@teusbenschop
Add categories to the styles
444ac9b 
#990
teusbenschop added a commit that referenced this issue Feb 22, 2025
@teusbenschop
Display categories in styles editor overview
b981945 
#990
teusbenschop added a commit that referenced this issue Feb 22, 2025
@teusbenschop
Unit test for style as yet uncategorized
55bcd32 
#990
teusbenschop added a commit that referenced this issue Feb 22, 2025
@teusbenschop
Support for \sts
b2068bd 
#990
teusbenschop added a commit that referenced this issue Feb 23, 2025
@teusbenschop
Working towards support for \pro ...\pro*
6286a80 
#990
teusbenschop added a commit that referenced this issue Feb 24, 2025
@teusbenschop
Unit test added
2ca4351 
#990
teusbenschop added a commit that referenced this issue Feb 27, 2025
@teusbenschop
Expand "road_is_clear" for styles v2 too
dc6d5c1 
#990
teusbenschop added a commit that referenced this issue Feb 27, 2025
@teusbenschop
More unit tests and cleanup
f074399 
#990
One unit tests locks behaviour about testing all styles v2.
One unit test secures behaviour about USFM having all markers defined in styles v2.
teusbenschop added a commit that referenced this issue Feb 27, 2025
@teusbenschop
Unit test on routine to import USFM
ff568d6 
#990
teusbenschop added a commit that referenced this issue Feb 27, 2025
@teusbenschop
Non-fatal failures in unit tests plus cleanup
9b7ae1f 
#990
teusbenschop added a commit that referenced this issue Feb 28, 2025
@teusbenschop
Unit test for usfm->html->usfm with all markup so far in v2
2d7444b 
This unit test takes the ever expanding USFM with all markup already moved to v2.
Hence this unit test is dynamic to always cover all possible and supported USFM markers.
#990
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teusbenschop teusbenschop

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@teusbenschop