Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune OkHttpClient settings #84

Open
jorkey opened this issue Jun 14, 2023 · 2 comments
Open

Tune OkHttpClient settings #84

jorkey opened this issue Jun 14, 2023 · 2 comments
Labels

Comments

@jorkey
Copy link

jorkey commented Jun 14, 2023

Hello.
How can I set OkHttpClient properties with binance-connector-java?
I want to enable pings for WebSocket connections.
OkHttpClient has property pingIntervalMillis, that initialized from OkHttpClient.Builder.
But binance-connector-java calls constructor of OkHttpClient with default Builder.

@aisling-2
Copy link
Contributor

Hi @jorkey,
it's currently not possible to change the default settings of OkHttpClient at WebSocketStreamHttpClientSingleton.

We could explore this in the future, but in the meantime to accelerate the investigation and integration, if you already have an idea on the implementation, feel free to open a PR :)

@jorkey
Copy link
Author

jorkey commented Jun 16, 2023

Hi @aisling-2, thank you for replay.
I tried to solve this problem here #85.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants