Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap #22

Open
5 of 9 tasks
Ehesp opened this issue Dec 7, 2015 · 19 comments
Open
5 of 9 tasks

Roadmap #22

Ehesp opened this issue Dec 7, 2015 · 19 comments

Comments

@Ehesp
Copy link
Contributor

Ehesp commented Dec 7, 2015

As much as I like this project, I feel there's quite a bit which needs improving for it to be maintainable. Also, @binggg do you have time to manage this on your own? Anyway a list:

  • Support React 0.16 & Babel 6 - I have this working locally, Support Babel 6 #21 - however in my eyes the project should support 0.16.* only in my eyes, since there's some big changes in it.
  • Have React Native 0.16 as a peer dependancy
  • Linting files with ESLint (Use a Code Quality Tool like ESLint #15) - Loads of inconsistencies, unused code etc.
  • Fixing the Ripple state bug (Long press toggles the state of the component permanently #9)
  • Tests - currently it's hard to make changes to components because I have no idea if the change will break something else.
  • Documentation - Could do with some more examples/spell-checking etc
  • Contributing Guidelines
  • Have react-native-vector-icons as a project dependancy
  • Break this project down into an organisation? Would be better to have multiple repositories in the same place, although this is @binggg's call.

Please provide feedback on these, this project is easily the best material one out there at the moment, just needs some loving.

@carbureted
Copy link

+1. I would love to see this project become bulletproof, and would also be willing to contribute to help make that happen.

@binggg
Copy link
Owner

binggg commented Dec 8, 2015

I'm glad to hear that.
Very busy recently, I will consider your proposal, thank you for your enthusiasm

@Ehesp
Copy link
Contributor Author

Ehesp commented Dec 8, 2015

OK great, let us know what you want to do, plenty to get on with!

@mrcasals
Copy link
Contributor

mrcasals commented Dec 8, 2015

I can help too! :)

@Ehesp
Copy link
Contributor Author

Ehesp commented Dec 9, 2015

@binggg had anymore thought on this?

@vongkim
Copy link

vongkim commented Dec 9, 2015

+1 I would like to help too.

@Ehesp
Copy link
Contributor Author

Ehesp commented Dec 10, 2015

I think tomorrow I'm going to setup an organisation on here to continue this project, I need this stuff for work and there's plenty to do, @binggg if you've anything against this please let me know!

@binggg
Copy link
Owner

binggg commented Dec 11, 2015

okay

@Ehesp
Copy link
Contributor Author

Ehesp commented Dec 11, 2015

An FYI - I've done the following:

  • Cleaned up all of the components, using ESLint
  • Fixed a bunch of issues
  • Got it working with RN 0.16

There's a couple of things I've done differently like using the default font from react native vector icons which requires way less setup.

I'll make an org for this later, GitHub is telling me the one I made is suspicious...

@Ehesp
Copy link
Contributor Author

Ehesp commented Dec 11, 2015

I've pushed the initial repository up to:

https://github.com/material-react-native/mrn

It includes a variety of fixes and improvements, hopefully now it's on an organisation it'll be easier to manage!

@Ehesp
Copy link
Contributor Author

Ehesp commented Dec 14, 2015

@binggg What do you want me to do now? The repo has been setup and everything has been ported across with loads of bug fixes and cleanup.

However the problem I have now is that unless you want to keep the project as "mrn" then I cannot push it to NPM (and hence can't publicly use it). The options are:

  1. Delete the other organisation (I'll keep the code), and you change/push this one into a new organisation. This will keep the stars/followers/issues.
  2. Deprecate this one with a link to the other organisation repo. This will lose all stars etc.
  3. Push it up to NPM as a new package, and credit you in the README. Again will lose stars etc.

Please let me know what you want to do ASAP so I can push it publicly.

@dgilperez
Copy link

Great effort!

If I'm not mistaken, @binggg could promote this project to a new org, and then give @Ehesp commit permissions so he can cherry pick the new changes and release a new version. This way stars would be preserved and there should not be any issues with project name.

+1 on supporting only > 0.16. By the way, 0.17 is out!

@Ehesp
Copy link
Contributor Author

Ehesp commented Dec 20, 2015

@dgilperez Well I didn't get a response from binggg so I had to make it into my own NPM lib. I've done a ton more work on it and will probably be pushing it all tomorrow. Working well on my device right now.

@bozzmob
Copy link

bozzmob commented Dec 25, 2015

WOW @Ehesp Amazing work! Really appreciate it and would like to contribute. And thanks @binggg for the initial effort for working on this.

@efkan
Copy link

efkan commented Jan 7, 2016

Is there any plan designing Cards like this ?

@Ehesp
Copy link
Contributor Author

Ehesp commented Jan 7, 2016

@efkan
Copy link

efkan commented Jan 7, 2016

OK. This is awesome :)
Thanks!

@binggg
Copy link
Owner

binggg commented Jan 7, 2016

Guys, I have been busy with my new job and my wedding, it seems I left behind many, I have to catch up with it

@efkan
Copy link

efkan commented Mar 9, 2016

Is there any chance to convert Material Design Lite components into React-Native and import to MRN ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants