Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join forces with my tonic_lnd? #28

Open
Kixunil opened this issue Dec 15, 2021 · 2 comments
Open

Join forces with my tonic_lnd? #28

Kixunil opened this issue Dec 15, 2021 · 2 comments

Comments

@Kixunil
Copy link

Kixunil commented Dec 15, 2021

I made and released the tonic_lnd crate and I wonder if you'd be interested in cooperating on a single crate which would be hopefully more efficient. From cursory look I don't see significant differences between our crates so switching shouldn't be too hard?

@lsunsi
Copy link
Contributor

lsunsi commented Dec 15, 2021

It's awesome to know that there are other people working in the same space as us! That said, for our purposes at @bipa-app it's best to keep our open source version that we support. Comparing the projects I see they really are pretty similar, so there's more reason for us to keep our version than to make a change at the present time. That said it'd be awesome to see your project grow and even more awesome if you think contributing to lnd-rs would be in your interest as well as ours. I'm always open to reviewing PRs as @daveajones recently saw. If we differ more dramatically between implementations in the future, I'd consider changing in the future!

@Kixunil
Copy link
Author

Kixunil commented Dec 15, 2021

Thinking about it maybe it'd make more sense to discuss our future plans with the libraries to see if we plan to do the same thing and thus we could split the work.

For my use cases tonic_lnd works quite well so far but I intend to test the API more in the future. Probably the largest change I intend is overriding some types with those of ln-types (the crate may also be of interest to you).
Xtask pattern also looks very interesting, so I'd like to give it a shot.

Eventually, I'd also like to write a separate, higher-level crate that would make the API more convenient (e.g get_info not requiring an argument) and abstract over multiple implementations (Eclair, C-Lightning). While a separate crate it might make sense to use it here.

I understand that you want to ensure reliability of your version and it's good that you do that. An alternative approach to your own library may be just having fork that you just sync with upstream and if shit hits the fan (upstream devs taking too much time for review) you deploy your change before merging upstream.

There's also the trust issue. If there are multiple interested developers I'd like the crate to be developed using a GH organization. (possibly rust-bitcoin if folks over there agree)
In case you're (rightly!) careful about trusting an internet stranger (me), here's some thing that may help:

  • I created and contributed to various FOSS projects (ignore donate, scroll down to see the things I did)
  • I recently became a collaborator of the rust-bitcoin crate
  • I know a few well-known bitcoiners such as Max Hillebrand, Giacomo Zucco, Maxim Orlovsky, you can check my reputation with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants