Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide one preferred way (ideally with DI) of providing test address books #1305

Open
Tracked by #1286
rfc2822 opened this issue Feb 9, 2025 · 0 comments
Open
Tracked by #1286
Assignees

Comments

@rfc2822
Copy link
Member

rfc2822 commented Feb 9, 2025

Are they even necessary or can normal LocalAddressBookss used?

In any case, the code that manages test address books should be in a Hilt (→ no Context passing) class, be it LocalAddressBookStore or an extension of it or a separate one.

So:

  • Think about better class/test design (including testing philosophy: mock vs fake class vs real class).
  • Decide whether LocalTestAddressBook is necessary.
  • Check subclasses vs interfaces vs extension methods.
@rfc2822 rfc2822 mentioned this issue Feb 9, 2025
5 tasks
@rfc2822 rfc2822 changed the title Provide one preferred way (ideally with DI) of providing test address books. (Are they even necessary or can normal LocalAddressBookss used?) Provide one preferred way (ideally with DI) of providing test address books Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants