Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAKER and TAKER are reversed in dxGetOrderHistory #623

Open
walkjivefly opened this issue Mar 6, 2022 · 0 comments
Open

MAKER and TAKER are reversed in dxGetOrderHistory #623

walkjivefly opened this issue Mar 6, 2022 · 0 comments

Comments

@walkjivefly
Copy link

The help for dxGetOrderHistory shows the parms as

blocknet-cli help dxGetOrderHistory
dxGetOrderHistory "maker" "taker" start_time end_time granularity ( order_ids with_inverse limit )

but the results show maker and taker were interpreted the other way around.

For example, between 1/1/22 and 5/1/22 I made 5 testnet trades with XVG:

Maker Taker Order#
XVG    SYS   6f556f678dd8e5e8e161a05865d77c51d6ecc482694719e402d6efd1e7eaf823
UNO   XVG   a9f4b2a2d9c3f93ee80fd32695aa8724d7ab3b90776128be415f592c13c8e2fe
XVG    MUE   d4ec354d0930e083494a86f68cc094600008085ad8011e7fd3ba09f8e21a2179
XVG    MUE   32751f5a5f84c27346f64175fbd0ec5de883c1c0b575a56387d5ace6b44c45d8
MUE   XVG   1add7d1d3e4ce2177243e0227418627f0dc33401e19fc886021cf7605d7d97ce

but the output from dxGetOrderHistory shows the maker and taker are reversed (OHLCV omitted for brevity), eg:

root@4ac2d3a8e34f:/opt/blockchain/data/log# blocknet-cli dxGetOrderHistory XVG SYS 1640908800 1641427200 86400 true false
[
  [
    "2021-12-31T00:00:00.000Z",
    [
    ]
  ],
  [
    "2022-01-01T00:00:00.000Z",
    [
    ]
  ],
  [
    "2022-01-02T00:00:00.000Z",
    [
    ]
  ],
  [
    "2022-01-03T00:00:00.000Z",
    [
    ]
  ],
  [
    "2022-01-04T00:00:00.000Z",
    [
    ]
  ],
  [
    "2022-01-05T00:00:00.000Z",
    [
    ]
  ]
]

root@4ac2d3a8e34f:/opt/blockchain/data/log# blocknet-cli dxGetOrderHistory SYS XVG 1640908800 1641427200 86400 true false
[
  [
    "2021-12-31T00:00:00.000Z",
    [
    ]
  ],
  [
    "2022-01-01T00:00:00.000Z",
    [
      "6f556f678dd8e5e8e161a05865d77c51d6ecc482694719e402d6efd1e7eaf823"
    ]
  ],
  [
    "2022-01-02T00:00:00.000Z",
    [
    ]
  ],
  [
    "2022-01-03T00:00:00.000Z",
    [
    ]
  ],
  [
    "2022-01-04T00:00:00.000Z",
    [
    ]
  ],
  [
    "2022-01-05T00:00:00.000Z",
    [
    ]
  ]
]

Parameter order and help text should be consistent.

The results from dxGetTradingData are correct but note that it returns results with data in the order ... taker, maker

Blocknet 4.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant