From 9b275104a5a1a0e47a6736283ffbe439103ec0c0 Mon Sep 17 00:00:00 2001 From: Jeffrey Mendelsohn Date: Thu, 11 Jul 2024 10:39:01 -0400 Subject: [PATCH] reduce td warnings (#4822) * reduce td warnings * remove bad whitespace --- groups/bdl/bdlat/bdlat_arrayfunctions.t.cpp | 4 +-- .../bdlat/bdlat_nullablevaluefunctions.t.cpp | 4 +-- groups/bdl/bdlat/bdlat_typecategory.t.cpp | 18 +++++----- groups/bdl/bdlat/bdlat_typename.t.cpp | 14 ++++++-- groups/bdl/bdlb/bdlb_bitstringimputil.t.cpp | 14 ++++---- groups/bdl/bdlb/bdlb_nullablevalue.t.cpp | 12 +++---- groups/bdl/bdlb/bdlb_printmethods.t.cpp | 6 ++-- groups/bdl/bdlb/bdlb_stringrefutil.t.cpp | 2 +- groups/bdl/bdlb/bdlb_stringviewutil.t.cpp | 2 +- groups/bdl/bdlb/bdlb_testinputiterator.t.cpp | 7 ++++ groups/bdl/bdlb/bdlb_tokenizer.t.cpp | 10 ++++-- groups/bdl/bdlb/bdlb_transformiterator.t.cpp | 7 ++++ groups/bdl/bdlb/bdlb_variant.t.cpp | 9 ++++- groups/bdl/bdlc/bdlc_bitarray.t.cpp | 1 - groups/bdl/bdlc/bdlc_compactedarray.t.cpp | 2 ++ groups/bdl/bdlc/bdlc_indexclerk.t.cpp | 7 ++++ groups/bdl/bdlc/bdlc_packedintarray.t.cpp | 4 +++ groups/bdl/bdlcc/bdlcc_cache.t.cpp | 4 +-- .../bdlcc/bdlcc_fixedqueueindexmanager.t.cpp | 1 - groups/bdl/bdlcc/bdlcc_objectcatalog.t.cpp | 8 +++++ groups/bdl/bdlcc/bdlcc_objectpool.t.cpp | 18 +++++++--- groups/bdl/bdlcc/bdlcc_skiplist.t.cpp | 6 ++-- .../bdlcc_stripedunorderedcontainerimpl.t.cpp | 8 ++--- .../bdl/bdlcc/bdlcc_stripedunorderedmap.t.cpp | 8 ++--- .../bdlcc_stripedunorderedmultimap.t.cpp | 8 ++--- groups/bdl/bdlde/bdlde_base64decoder.t.cpp | 2 +- groups/bdl/bdlde/bdlde_charconvertutf16.t.cpp | 11 ++++++- .../bdlde/bdlde_quotedprintableencoder.t.cpp | 2 +- .../bdldfp/bdldfp_decimalconvertutil.t.cpp | 2 -- groups/bdl/bdlf/bdlf_noop.t.cpp | 4 +-- groups/bdl/bdljsn/bdljsn_json.t.cpp | 33 +++++++++++++++---- .../bdl/bdljsn/bdljsn_jsontestsuiteutil.t.cpp | 4 +-- groups/bdl/bdlm/bdlm_metricdescriptor.t.cpp | 6 ++-- groups/bdl/bdlm/bdlm_metricsregistry.t.cpp | 7 ++++ groups/bdl/bdlma/bdlma_blocklist.t.cpp | 6 ++-- .../bdl/bdlma/bdlma_concurrentfixedpool.t.cpp | 6 ++++ groups/bdl/bdlma/bdlma_concurrentpool.t.cpp | 10 ++++-- .../bdl/bdlma/bdlma_countingallocator.t.cpp | 12 +++---- .../bdl/bdlma/bdlma_guardingallocator.t.cpp | 4 +-- .../bdlma_infrequentdeleteblocklist.t.cpp | 2 +- .../bdlma/bdlma_memoryblockdescriptor.t.cpp | 7 ++++ groups/bdl/bdlma/bdlma_pool.t.cpp | 6 ++++ groups/bdl/bdlsb/bdlsb_memoutstreambuf.t.cpp | 4 --- groups/bdl/bdlsta/bdlsta_linefit.t.cpp | 7 ++++ groups/bdl/bdlsta/bdlsta_moment.t.cpp | 7 ++++ groups/bdl/bdlt/bdlt_calendar.t.cpp | 15 ++++++--- groups/bdl/bdlt/bdlt_calendarcache.t.cpp | 24 +++++++------- groups/bdl/bdlt/bdlt_datetime.t.cpp | 3 +- groups/bdl/bdlt/bdlt_dayofweekset.t.cpp | 6 ++++ groups/bdl/bdlt/bdlt_fixutil.t.cpp | 3 +- groups/bdl/bdlt/bdlt_iso8601util.00.t.cpp | 12 ++++--- groups/bdl/bdlt/bdlt_packedcalendar.t.cpp | 8 ++--- groups/bdl/bdlt/bdlt_timetable.t.cpp | 6 ++-- groups/bdl/bdlt/bdlt_timetablecache.t.cpp | 24 +++++++------- groups/bdl/bdlt/bdlt_timetz.t.cpp | 7 ++++ groups/bdl/bdlt/bdlt_timeutil.t.cpp | 3 +- 56 files changed, 300 insertions(+), 137 deletions(-) diff --git a/groups/bdl/bdlat/bdlat_arrayfunctions.t.cpp b/groups/bdl/bdlat/bdlat_arrayfunctions.t.cpp index bba08a2c3d..a12c563a83 100644 --- a/groups/bdl/bdlat/bdlat_arrayfunctions.t.cpp +++ b/groups/bdl/bdlat/bdlat_arrayfunctions.t.cpp @@ -248,7 +248,7 @@ int GetValue::operator()(const LVALUE_TYPE& object) const template template -int GetValue::operator()(const RVALUE_TYPE& object) const +int GetValue::operator()(const RVALUE_TYPE& /* object */) const { return -1; } @@ -276,7 +276,7 @@ int AssignValue::operator()(RVALUE_TYPE *object) const template template -int AssignValue::operator()(LVALUE_TYPE *object) const +int AssignValue::operator()(LVALUE_TYPE * /* object */) const { return -1; } diff --git a/groups/bdl/bdlat/bdlat_nullablevaluefunctions.t.cpp b/groups/bdl/bdlat/bdlat_nullablevaluefunctions.t.cpp index 33f64b2f95..5883eb1369 100644 --- a/groups/bdl/bdlat/bdlat_nullablevaluefunctions.t.cpp +++ b/groups/bdl/bdlat/bdlat_nullablevaluefunctions.t.cpp @@ -158,7 +158,7 @@ int GetValue::operator()(const LVALUE_TYPE& object) const template template -int GetValue::operator()(const RVALUE_TYPE& object) const +int GetValue::operator()(const RVALUE_TYPE& /* object */) const { return -1; } @@ -186,7 +186,7 @@ int AssignValue::operator()(RVALUE_TYPE *object) const template template -int AssignValue::operator()(LVALUE_TYPE *object) const +int AssignValue::operator()(LVALUE_TYPE * /* object */) const { return -1; } diff --git a/groups/bdl/bdlat/bdlat_typecategory.t.cpp b/groups/bdl/bdlat/bdlat_typecategory.t.cpp index ba5c46fd0d..6d6f21b349 100644 --- a/groups/bdl/bdlat/bdlat_typecategory.t.cpp +++ b/groups/bdl/bdlat/bdlat_typecategory.t.cpp @@ -1104,7 +1104,7 @@ int main(int argc, char *argv[]) { typedef int Type; - Type object; + Type object = 0; MyAccessor accessor; ASSERT(bdlat_TypeCategory::e_SIMPLE_CATEGORY @@ -1115,7 +1115,7 @@ int main(int argc, char *argv[]) { typedef char Type; - Type object; + Type object = ' '; MyAccessor accessor; ASSERT(bdlat_TypeCategory::e_SIMPLE_CATEGORY @@ -1126,7 +1126,7 @@ int main(int argc, char *argv[]) { typedef float Type; - Type object; + Type object = 0.0; MyAccessor accessor; ASSERT(bdlat_TypeCategory::e_SIMPLE_CATEGORY @@ -1554,7 +1554,7 @@ int main(int argc, char *argv[]) { typedef int Type; - Type object; + Type object = 0; MyAccessor accessor; ASSERT(-1 == bdlat_TypeCategoryFunctions:: @@ -1583,7 +1583,7 @@ int main(int argc, char *argv[]) { typedef char Type; - Type object; + Type object = ' '; MyAccessor accessor; ASSERT(-1 == bdlat_TypeCategoryFunctions:: @@ -1612,7 +1612,7 @@ int main(int argc, char *argv[]) { typedef float Type; - Type object; + Type object = 0.0; MyAccessor accessor; ASSERT(-1 == bdlat_TypeCategoryFunctions:: @@ -2104,7 +2104,7 @@ int main(int argc, char *argv[]) { typedef int Type; - Type object; + Type object = 0; ASSERT(bdlat_TypeCategory::e_SIMPLE_CATEGORY == bdlat_TypeCategoryFunctions::select(object)); @@ -2113,7 +2113,7 @@ int main(int argc, char *argv[]) { typedef char Type; - Type object; + Type object = ' '; ASSERT(bdlat_TypeCategory::e_SIMPLE_CATEGORY == bdlat_TypeCategoryFunctions::select(object)); @@ -2122,7 +2122,7 @@ int main(int argc, char *argv[]) { typedef float Type; - Type object; + Type object = 0.0; ASSERT(bdlat_TypeCategory::e_SIMPLE_CATEGORY == bdlat_TypeCategoryFunctions::select(object)); diff --git a/groups/bdl/bdlat/bdlat_typename.t.cpp b/groups/bdl/bdlat/bdlat_typename.t.cpp index 25b1f17d84..d0a43c6857 100644 --- a/groups/bdl/bdlat/bdlat_typename.t.cpp +++ b/groups/bdl/bdlat/bdlat_typename.t.cpp @@ -45,11 +45,19 @@ #include #include +#include #include using namespace BloombergLP; using namespace bsl; +#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC +#ifdef BSLS_PLATFORM_CMP_CLANG +#pragma GCC diagnostic ignored "-Wuninitialized-const-reference" +#pragma GCC diagnostic ignored "-Wunused-private-field" +#endif +#endif + // ============================================================================ // TEST PLAN // ---------------------------------------------------------------------------- @@ -258,7 +266,7 @@ bool streq(const char* s1, const char* s2) #define CLASSNAME_TST(Type, exp) { \ Type object; \ - const char *expected = exp ? exp : ""; \ + const char *expected = 0 != exp ? exp : ""; \ const char *result = Obj::className(object); \ if (0 == result) result = ""; \ LOOP2_ASSERT(result, expected, streq(result, expected)); \ @@ -266,7 +274,7 @@ bool streq(const char* s1, const char* s2) #define NAME_TST(Type, exp) { \ Type object; \ - const char *expected = exp ? exp : ""; \ + const char *expected = 0 != exp ? exp : ""; \ const char *result = Obj::name(object); \ if (0 == result) result = ""; \ LOOP2_ASSERT(result, expected, streq(result, expected)); \ @@ -274,7 +282,7 @@ bool streq(const char* s1, const char* s2) #define XSDNAME_TST(Type, fmt, exp) { \ Type object; \ - const char *expected = exp ? exp : ""; \ + const char *expected = 0 != exp ? exp : ""; \ const char *result = Obj::xsdName(object, fmt); \ if (0 == result) result = ""; \ LOOP2_ASSERT(result, expected, streq(result, expected)); \ diff --git a/groups/bdl/bdlb/bdlb_bitstringimputil.t.cpp b/groups/bdl/bdlb/bdlb_bitstringimputil.t.cpp index 74fefb26e9..76c3be2924 100644 --- a/groups/bdl/bdlb/bdlb_bitstringimputil.t.cpp +++ b/groups/bdl/bdlb/bdlb_bitstringimputil.t.cpp @@ -330,29 +330,29 @@ static uint64_t g(const char *spec) } break; case '.': { if (-1 != rangeStartIndex) { - LOOP2_ASSERT(i, spec[i], G_OFF || !"Multiple Ranges"); + LOOP2_ASSERT(i, spec[i], G_OFF || 0 == "Multiple Ranges"); return G_MULTIPLE_RANGES; // RETURN } if (0 == bitCount) { - LOOP2_ASSERT(i, spec[i], G_OFF || !"Missing Range Start"); + LOOP2_ASSERT(i, spec[i], G_OFF || 0 == "Missing Range Start"); return G_MISSING_RANGE_START; // RETURN } while (isspace(spec[++i])) { // skip whitespace } if ('.' != spec[i]) { - LOOP2_ASSERT(i, spec[i], G_OFF || !"Missing Second Dot"); + LOOP2_ASSERT(i, spec[i], G_OFF || 0 == "Missing Second Dot"); return G_MISSING_SECOND_DOT; // RETURN } while (isspace(spec[++i])) { // skip whitespace } if ('0' != spec[i] && '1' != spec[i]) { - LOOP2_ASSERT(i, spec[i], G_OFF || !"Missing Range End"); + LOOP2_ASSERT(i, spec[i], G_OFF || 0 == "Missing Range End"); return G_MISSING_RANGE_END; // RETURN } if (spec[i] != spec[lastBitIndex]) { - LOOP2_ASSERT(i, spec[i], G_OFF || !"Nonmatching Range"); + LOOP2_ASSERT(i, spec[i], G_OFF || 0 == "Nonmatching Range"); return G_MISMATCHED_RANGE; // RETURN } @@ -363,7 +363,7 @@ static uint64_t g(const char *spec) } break; default: { if (!isspace(spec[i])) { - LOOP2_ASSERT(i, spec[i], G_OFF || !"Illegal Character"); + LOOP2_ASSERT(i, spec[i], G_OFF || 0 == "Illegal Character"); return G_ILLEGAL_CHARACTER; // RETURN } } break; @@ -371,7 +371,7 @@ static uint64_t g(const char *spec) } if (bitCount > BITS_PER_UINT64) { - LOOP2_ASSERT(bitCount, BITS_PER_UINT64, G_OFF || !"Too Many Bits"); + LOOP2_ASSERT(bitCount, BITS_PER_UINT64, G_OFF || 0 == "Too Many Bits"); return G_TOO_MANY_BITS; // RETURN } diff --git a/groups/bdl/bdlb/bdlb_nullablevalue.t.cpp b/groups/bdl/bdlb/bdlb_nullablevalue.t.cpp index ccd3cf3229..8f84a67a6c 100644 --- a/groups/bdl/bdlb/bdlb_nullablevalue.t.cpp +++ b/groups/bdl/bdlb/bdlb_nullablevalue.t.cpp @@ -3415,7 +3415,7 @@ void TestDriver::testCase23_withAllocator() srcAllocatorPtr = &oa; } break; default: { - ASSERTV(CONFIG, !"Bad allocator config."); + ASSERTV(CONFIG, 0 == "Bad allocator config."); } return; // RETURN } @@ -3521,7 +3521,7 @@ void TestDriver::testCase23_withAllocator() srcAllocatorPtr = &oa; } break; default: { - ASSERTV(CONFIG, !"Bad allocator config."); + ASSERTV(CONFIG, 0 == "Bad allocator config."); } return; // RETURN } bslma::TestAllocator& sa = *srcAllocatorPtr; @@ -3851,7 +3851,7 @@ void TestDriver::testCase22_withAllocator() othAllocatorPtr = &da; } break; default: { - ASSERTV(CONFIG, !"Bad allocator config."); + ASSERTV(CONFIG, 0 == "Bad allocator config."); } return; // RETURN } @@ -4210,7 +4210,7 @@ void TestDriver::testCase21_withAllocator() srcAllocatorPtr = &oa; } break; default: { - ASSERTV(CONFIG, !"Bad allocator config."); + ASSERTV(CONFIG, 0 == "Bad allocator config."); } return; // RETURN } bslma::TestAllocator& sa = *srcAllocatorPtr; @@ -4344,7 +4344,7 @@ void TestDriver::testCase21_withAllocator() srcAllocatorPtr = &oa; } break; default: { - ASSERTV(CONFIG, !"Bad allocator config."); + ASSERTV(CONFIG, 0 == "Bad allocator config."); } return; // RETURN } bslma::TestAllocator& sa = *srcAllocatorPtr; @@ -4658,7 +4658,7 @@ void TestDriver::testCase20_withAllocator() othAllocatorPtr = &da; } break; default: { - ASSERTV(CONFIG, !"Bad allocator config."); + ASSERTV(CONFIG, 0 == "Bad allocator config."); } return; // RETURN } diff --git a/groups/bdl/bdlb/bdlb_printmethods.t.cpp b/groups/bdl/bdlb/bdlb_printmethods.t.cpp index 12b4fdb947..680c5c9cdf 100644 --- a/groups/bdl/bdlb/bdlb_printmethods.t.cpp +++ b/groups/bdl/bdlb/bdlb_printmethods.t.cpp @@ -919,7 +919,7 @@ int main(int argc, char *argv[]) EXPECTED_VALUE = "45"; } break; default: { - ASSERTV(CONFIG, !"Reachable"); + ASSERTV(CONFIG, 0 == "Reachable"); } break; } @@ -1076,7 +1076,7 @@ int main(int argc, char *argv[]) EXPECTED_VALUE = "Six"; } break; default: { - ASSERTV(CONFIG, !"Reachable"); + ASSERTV(CONFIG, 0 == "Reachable"); } break; } @@ -1196,7 +1196,7 @@ int main(int argc, char *argv[]) DFT)); } break; default: { - ASSERTV(CONFIG, !"Reachable"); + ASSERTV(CONFIG, 0 == "Reachable"); } break; } } diff --git a/groups/bdl/bdlb/bdlb_stringrefutil.t.cpp b/groups/bdl/bdlb/bdlb_stringrefutil.t.cpp index 75033a929a..1c786c56f8 100644 --- a/groups/bdl/bdlb/bdlb_stringrefutil.t.cpp +++ b/groups/bdl/bdlb/bdlb_stringrefutil.t.cpp @@ -1195,7 +1195,7 @@ int main(int argc, char *argv[]) areSameCaseStrSubstr = true; } break; default: { - LOOP_ASSERT(cfg, !"Unknown 'cfg'"); + LOOP_ASSERT(cfg, 0 == "Unknown 'cfg'"); } break; }; diff --git a/groups/bdl/bdlb/bdlb_stringviewutil.t.cpp b/groups/bdl/bdlb/bdlb_stringviewutil.t.cpp index d526299bc7..66bbf6be2c 100644 --- a/groups/bdl/bdlb/bdlb_stringviewutil.t.cpp +++ b/groups/bdl/bdlb/bdlb_stringviewutil.t.cpp @@ -1521,7 +1521,7 @@ int main(int argc, char *argv[]) areSameCaseStrSubstr = true; } break; default: { - LOOP_ASSERT(cfg, !"Unknown 'cfg'"); + LOOP_ASSERT(cfg, 0 == "Unknown 'cfg'"); } break; }; diff --git a/groups/bdl/bdlb/bdlb_testinputiterator.t.cpp b/groups/bdl/bdlb/bdlb_testinputiterator.t.cpp index 3d28fe10ae..d938ed8d55 100644 --- a/groups/bdl/bdlb/bdlb_testinputiterator.t.cpp +++ b/groups/bdl/bdlb/bdlb_testinputiterator.t.cpp @@ -10,10 +10,17 @@ #include // for testing only #include +#include using namespace BloombergLP; using namespace bsl; +#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC +#ifdef BSLS_PLATFORM_CMP_CLANG +#pragma GCC diagnostic ignored "-Wself-assign-overloaded" +#endif +#endif + // ============================================================================ // TEST PLAN // ---------------------------------------------------------------------------- diff --git a/groups/bdl/bdlb/bdlb_tokenizer.t.cpp b/groups/bdl/bdlb/bdlb_tokenizer.t.cpp index ebfbf156b8..7d97c6c41d 100644 --- a/groups/bdl/bdlb/bdlb_tokenizer.t.cpp +++ b/groups/bdl/bdlb/bdlb_tokenizer.t.cpp @@ -18,13 +18,19 @@ #include // for 'std::string' +using namespace BloombergLP; +using namespace bsl; + #if defined(BSLS_PLATFORM_CMP_MSVC) #pragma warning(disable:4553) #pragma warning(disable:4834) #endif -using namespace BloombergLP; -using namespace bsl; +#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC +#ifdef BSLS_PLATFORM_CMP_CLANG +#pragma GCC diagnostic ignored "-Wself-assign-overloaded" +#endif +#endif // ============================================================================ // TEST PLAN diff --git a/groups/bdl/bdlb/bdlb_transformiterator.t.cpp b/groups/bdl/bdlb/bdlb_transformiterator.t.cpp index 6e6f9e21e5..0f6c2caa24 100644 --- a/groups/bdl/bdlb/bdlb_transformiterator.t.cpp +++ b/groups/bdl/bdlb/bdlb_transformiterator.t.cpp @@ -9,6 +9,7 @@ #include #include +#include #include #include @@ -23,6 +24,12 @@ using namespace BloombergLP; using namespace bdlb; using namespace bsl; +#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC +#ifdef BSLS_PLATFORM_CMP_CLANG +#pragma GCC diagnostic ignored "-Wmissing-braces" +#endif +#endif + // ============================================================================ // TEST PLAN // ---------------------------------------------------------------------------- diff --git a/groups/bdl/bdlb/bdlb_variant.t.cpp b/groups/bdl/bdlb/bdlb_variant.t.cpp index 4e9c36a89e..bbe9783a05 100644 --- a/groups/bdl/bdlb/bdlb_variant.t.cpp +++ b/groups/bdl/bdlb/bdlb_variant.t.cpp @@ -28,6 +28,7 @@ #include #include #include +#include #include #include @@ -74,6 +75,12 @@ using bsls::NameOf; #pragma error_messages(off, reftoref) #endif +#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC +#ifdef BSLS_PLATFORM_CMP_CLANG +#pragma GCC diagnostic ignored "-Wunused-private-field" +#endif +#endif + // ============================================================================ // TEST PLAN // ---------------------------------------------------------------------------- @@ -421,7 +428,7 @@ class TestAllocObj { // ACCESSORS template - STREAM& bdexStreamOut(STREAM& stream, int version) const + STREAM& bdexStreamOut(STREAM& stream, int /* version */) const // Stream bdex out to the specified 'stream'. { return stream; diff --git a/groups/bdl/bdlc/bdlc_bitarray.t.cpp b/groups/bdl/bdlc/bdlc_bitarray.t.cpp index f1b2f9a384..7d0bb1728e 100644 --- a/groups/bdl/bdlc/bdlc_bitarray.t.cpp +++ b/groups/bdl/bdlc/bdlc_bitarray.t.cpp @@ -242,7 +242,6 @@ typedef bool Element; static const uint64_t zero = 0; static const uint64_t minusOne = ~zero; -static const uint64_t one = 1; static const size_t k_INVALID_INDEX = Obj::k_INVALID_INDEX; diff --git a/groups/bdl/bdlc/bdlc_compactedarray.t.cpp b/groups/bdl/bdlc/bdlc_compactedarray.t.cpp index 6685498f44..cbc1ea28b7 100644 --- a/groups/bdl/bdlc/bdlc_compactedarray.t.cpp +++ b/groups/bdl/bdlc/bdlc_compactedarray.t.cpp @@ -4222,6 +4222,8 @@ int main(int argc, char *argv[]) objAllocatorPtr = &sa; } break; default: { + objPtr = 0; + objAllocatorPtr = 0; LOOP2_ASSERT(CONFIG, "Bad allocator config.", false); } break; } diff --git a/groups/bdl/bdlc/bdlc_indexclerk.t.cpp b/groups/bdl/bdlc/bdlc_indexclerk.t.cpp index 387076dcec..e4a0a7bde9 100644 --- a/groups/bdl/bdlc/bdlc_indexclerk.t.cpp +++ b/groups/bdl/bdlc/bdlc_indexclerk.t.cpp @@ -10,6 +10,7 @@ #include +#include #include #include @@ -29,6 +30,12 @@ using namespace BloombergLP; using namespace bsl; +#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC +#ifdef BSLS_PLATFORM_CMP_CLANG +#pragma GCC diagnostic ignored "-Wself-assign-overloaded" +#endif +#endif + // ============================================================================ // TEST PLAN // ---------------------------------------------------------------------------- diff --git a/groups/bdl/bdlc/bdlc_packedintarray.t.cpp b/groups/bdl/bdlc/bdlc_packedintarray.t.cpp index ab32ddb565..ee038691c1 100644 --- a/groups/bdl/bdlc/bdlc_packedintarray.t.cpp +++ b/groups/bdl/bdlc/bdlc_packedintarray.t.cpp @@ -6411,6 +6411,8 @@ int main(int argc, char *argv[]) objAllocatorPtr = &sa; } break; default: { + objPtr = 0; + objAllocatorPtr = 0; LOOP2_ASSERT(CONFIG, "Bad allocator config.", false); } break; } @@ -6584,6 +6586,8 @@ int main(int argc, char *argv[]) objAllocatorPtr = &sa; } break; default: { + objPtr = 0; + objAllocatorPtr = 0; LOOP2_ASSERT(CONFIG, "Bad allocator config.", false); } break; } diff --git a/groups/bdl/bdlcc/bdlcc_cache.t.cpp b/groups/bdl/bdlcc/bdlcc_cache.t.cpp index 4da5bb37de..42e8ec0d60 100644 --- a/groups/bdl/bdlcc/bdlcc_cache.t.cpp +++ b/groups/bdl/bdlcc/bdlcc_cache.t.cpp @@ -2874,7 +2874,7 @@ void TestDriver::testCase7() for (bsl::size_t v = 0; v < tj; ++v) { eraseKeysBsl.push_back(VALUES[v].first); } - bsl::size_t count; + bsl::size_t count = 0; switch (eraseBy) { case e_ERASE_BY_VECTOR: { @@ -3910,7 +3910,7 @@ void TestDriver::testCase2() objAllocatorPtr = &sa; } break; default: { - ASSERTV(CONFIG, !"Bad allocator config."); + ASSERTV(CONFIG, 0 == "Bad allocator config."); } return; // RETURN } diff --git a/groups/bdl/bdlcc/bdlcc_fixedqueueindexmanager.t.cpp b/groups/bdl/bdlcc/bdlcc_fixedqueueindexmanager.t.cpp index 0b9f02e949..ebdf54c92b 100644 --- a/groups/bdl/bdlcc/bdlcc_fixedqueueindexmanager.t.cpp +++ b/groups/bdl/bdlcc/bdlcc_fixedqueueindexmanager.t.cpp @@ -430,7 +430,6 @@ enum ElementState { static const unsigned int k_ELEMENT_STATE_MASK = 0x3; static const unsigned int k_GENERATION_COUNT_SHIFT = 0x2; -static const unsigned int k_DISABLED_STATE_MASK = 1 << ((sizeof(int) * 8) - 1); BSLMF_ASSERT(sizeof(FixedQueueIndexManagerDataMembers) == sizeof(bdlcc::FixedQueueIndexManager)); diff --git a/groups/bdl/bdlcc/bdlcc_objectcatalog.t.cpp b/groups/bdl/bdlcc/bdlcc_objectcatalog.t.cpp index a185cb3ad5..4c364d554e 100644 --- a/groups/bdl/bdlcc/bdlcc_objectcatalog.t.cpp +++ b/groups/bdl/bdlcc/bdlcc_objectcatalog.t.cpp @@ -13,6 +13,7 @@ #include +#include #include #include @@ -56,6 +57,12 @@ using bsl::cerr; using bsl::endl; using bsl::flush; +#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC +#ifdef BSLS_PLATFORM_CMP_CLANG +#pragma GCC diagnostic ignored "-Wunused-private-field" +#endif +#endif + //============================================================================= // TEST PLAN //----------------------------------------------------------------------------- @@ -959,6 +966,7 @@ bool operator==(const WellBehavedMoveOnlyAllocTestType& lhs, return lhs.data() == rhs.data(); } +BSLA_MAYBE_UNUSED inline bool operator!=(const WellBehavedMoveOnlyAllocTestType& lhs, const WellBehavedMoveOnlyAllocTestType& rhs) diff --git a/groups/bdl/bdlcc/bdlcc_objectpool.t.cpp b/groups/bdl/bdlcc/bdlcc_objectpool.t.cpp index 0bcc7516e6..91acef04fa 100644 --- a/groups/bdl/bdlcc/bdlcc_objectpool.t.cpp +++ b/groups/bdl/bdlcc/bdlcc_objectpool.t.cpp @@ -6,6 +6,8 @@ #include #include +#include + #include #include @@ -36,6 +38,12 @@ using namespace BloombergLP; using namespace bsl; +#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC +#ifdef BSLS_PLATFORM_CMP_CLANG +#pragma GCC diagnostic ignored "-Wunused-private-field" +#endif +#endif + //============================================================================= // TEST PLAN //----------------------------------------------------------------------------- @@ -1732,7 +1740,7 @@ int main(int argc, char *argv[]) bdlcc::ObjectPool mX; createBThrow = 0; - B *b1Ptr = mX.getObject(); // should not throw + BSLA_MAYBE_UNUSED B *b1Ptr = mX.getObject(); // should not throw ++b1Ptr; // satisfy gcc that b1Ptr is used ASSERT(mX.numObjects() == 1); ASSERT(mX.numAvailableObjects() == 0); @@ -1779,7 +1787,7 @@ int main(int argc, char *argv[]) bdlcc::ObjectPool mX; createBThrow = 0; - B *b1Ptr = mX.getObject(); // should not throw + BSLA_MAYBE_UNUSED B *b1Ptr = mX.getObject(); // should not throw ++b1Ptr; // satisfy gcc that b1Ptr is used ASSERT(mX.numObjects() == 1); ASSERT(mX.numAvailableObjects() == 0); @@ -1825,7 +1833,7 @@ int main(int argc, char *argv[]) bdlcc::ObjectPool mX; createBThrow = 0; - B *b1Ptr = mX.getObject(); // should not throw + BSLA_MAYBE_UNUSED B *b1Ptr = mX.getObject(); // should not throw ++b1Ptr; // satisfy gcc that b1Ptr is used ASSERT(mX.numObjects() == 1); ASSERT(mX.numAvailableObjects() == 0); @@ -2323,7 +2331,7 @@ int main(int argc, char *argv[]) numLastCreated = pool->numObjects(); my_CheckingClass *lastP = - (my_CheckingClass*) ((char *)p - k_OBJECT_FRAME_SIZE); + (my_CheckingClass*)(void *)((char *)p - k_OBJECT_FRAME_SIZE); for (int k = 1; k <= DATA[i][j]; ++k) { my_CheckingClass *currP = pool->getObject(); @@ -2336,7 +2344,7 @@ int main(int argc, char *argv[]) // verify that successive objects are separated by // 'k_OBJECT_FRAME_SIZE' bytes. my_CheckingClass *temp = - (my_CheckingClass *)((char *)lastP + k_OBJECT_FRAME_SIZE); + (my_CheckingClass *)(void *)((char *)lastP + k_OBJECT_FRAME_SIZE); LOOP5_ASSERT(i, j, k, (char*)lastP, (char*)currP, temp==currP); diff --git a/groups/bdl/bdlcc/bdlcc_skiplist.t.cpp b/groups/bdl/bdlcc/bdlcc_skiplist.t.cpp index 858cedec27..df9ebcaabf 100644 --- a/groups/bdl/bdlcc/bdlcc_skiplist.t.cpp +++ b/groups/bdl/bdlcc/bdlcc_skiplist.t.cpp @@ -8001,21 +8001,21 @@ if (veryVerbose) cout << "Elapsed: " << elapsed << " seconds\n"; cout << ",,,\n"; cout << "Stdev/Minimum %:,"; - if (userTimes[0]) { + if (0.0 != userTimes[0]) { cout << 100.0 * stddevs[0] / userTimes[0]; } else { cout << '*'; } cout << ','; - if (systemTimes[0]) { + if (0.0 != systemTimes[0]) { cout << 100.0 * stddevs[1] / systemTimes[0]; } else { cout << '*'; } cout << ','; - if (wallTimes[0]) { + if (0.0 != wallTimes[0]) { cout << 100.0 * stddevs[2] / wallTimes[0]; } else { diff --git a/groups/bdl/bdlcc/bdlcc_stripedunorderedcontainerimpl.t.cpp b/groups/bdl/bdlcc/bdlcc_stripedunorderedcontainerimpl.t.cpp index cb646a5dea..92fef5f64f 100644 --- a/groups/bdl/bdlcc/bdlcc_stripedunorderedcontainerimpl.t.cpp +++ b/groups/bdl/bdlcc/bdlcc_stripedunorderedcontainerimpl.t.cpp @@ -8757,7 +8757,7 @@ void TestDriver::testCase3() bslma::TestAllocator da("default", *vvvV); bslma::DefaultAllocatorGuard dag(&da); - int loopCount = 0; + int loopCount = 0; (void)loopCount; BSLMA_TESTALLOCATOR_EXCEPTION_TEST_BEGIN(sa) { ++loopCount; @@ -8882,7 +8882,7 @@ void TestDriver::testCase3() bslma::TestAllocator da("da", *vvvV); bslma::DefaultAllocatorGuard dag(&da); - int loopCount = 0; + int loopCount = 0; (void)loopCount; BSLMA_TESTALLOCATOR_EXCEPTION_TEST_BEGIN(sa) { ++loopCount; @@ -9206,7 +9206,7 @@ void TestDriver::testCase3() bslma::TestAllocator da("da", *vvvV); bslma::DefaultAllocatorGuard dag(&da); - int loopCount = 0; + int loopCount = 0; (void)loopCount; BSLMA_TESTALLOCATOR_EXCEPTION_TEST_BEGIN(sa) { ++loopCount; @@ -9507,7 +9507,7 @@ void TestDriver::testCase2() } break; default: { - ASSERTV(CONFIG, !"Bad allocator config."); + ASSERTV(CONFIG, 0 == "Bad allocator config."); } return; // RETURN } diff --git a/groups/bdl/bdlcc/bdlcc_stripedunorderedmap.t.cpp b/groups/bdl/bdlcc/bdlcc_stripedunorderedmap.t.cpp index 0d8475f030..f25dbf7a88 100644 --- a/groups/bdl/bdlcc/bdlcc_stripedunorderedmap.t.cpp +++ b/groups/bdl/bdlcc/bdlcc_stripedunorderedmap.t.cpp @@ -5952,7 +5952,7 @@ void TestDriver::testCase3() bslma::TestAllocator da("default" , *vvvV); bslma::DefaultAllocatorGuard dag(&da); - int loopCount = 0; + int loopCount = 0; (void)loopCount; BSLMA_TESTALLOCATOR_EXCEPTION_TEST_BEGIN(sa) { ++loopCount; @@ -6059,7 +6059,7 @@ void TestDriver::testCase3() bslma::TestAllocator da("da", *vvvV); bslma::DefaultAllocatorGuard dag(&da); - int loopCount = 0; + int loopCount = 0; (void)loopCount; BSLMA_TESTALLOCATOR_EXCEPTION_TEST_BEGIN(sa) { ++loopCount; @@ -6271,7 +6271,7 @@ void TestDriver::testCase3() bslma::TestAllocator da("da", *vvvV); bslma::DefaultAllocatorGuard dag(&da); - int loopCount = 0; + int loopCount = 0; (void)loopCount; BSLMA_TESTALLOCATOR_EXCEPTION_TEST_BEGIN(sa) { ++loopCount; @@ -6549,7 +6549,7 @@ void TestDriver::testCase2() } break; default: { - ASSERTV(CONFIG, !"Bad allocator config."); + ASSERTV(CONFIG, 0 == "Bad allocator config."); } return; // RETURN } diff --git a/groups/bdl/bdlcc/bdlcc_stripedunorderedmultimap.t.cpp b/groups/bdl/bdlcc/bdlcc_stripedunorderedmultimap.t.cpp index 325167ffe1..4966f18e32 100644 --- a/groups/bdl/bdlcc/bdlcc_stripedunorderedmultimap.t.cpp +++ b/groups/bdl/bdlcc/bdlcc_stripedunorderedmultimap.t.cpp @@ -7217,7 +7217,7 @@ void TestDriver::testCase3() bslma::TestAllocator da("default", *vvvV); bslma::DefaultAllocatorGuard dag(&da); - int loopCount = 0; + int loopCount = 0; (void)loopCount; BSLMA_TESTALLOCATOR_EXCEPTION_TEST_BEGIN(sa) { ++loopCount; @@ -7328,7 +7328,7 @@ void TestDriver::testCase3() bslma::TestAllocator da("da", *vvvV); bslma::DefaultAllocatorGuard dag(&da); - int loopCount = 0; + int loopCount = 0; (void)loopCount; BSLMA_TESTALLOCATOR_EXCEPTION_TEST_BEGIN(sa) { ++loopCount; @@ -7566,7 +7566,7 @@ void TestDriver::testCase3() bslma::TestAllocator da("da", *vvvV); bslma::DefaultAllocatorGuard dag(&da); - int loopCount = 0; + int loopCount = 0; (void)loopCount; BSLMA_TESTALLOCATOR_EXCEPTION_TEST_BEGIN(sa) { ++loopCount; @@ -7862,7 +7862,7 @@ void TestDriver::testCase2() } break; default: { - ASSERTV(CONFIG, !"Bad allocator config."); + ASSERTV(CONFIG, 0 == "Bad allocator config."); } return; // RETURN } diff --git a/groups/bdl/bdlde/bdlde_base64decoder.t.cpp b/groups/bdl/bdlde/bdlde_base64decoder.t.cpp index 138f751a88..da856dc4ec 100644 --- a/groups/bdl/bdlde/bdlde_base64decoder.t.cpp +++ b/groups/bdl/bdlde/bdlde_base64decoder.t.cpp @@ -4989,7 +4989,7 @@ DEFINE_TEST_CASE(9) // ** Prepare to process first 'convert' or 'endConvert'. ** int totalOut = 0; - int totalIn = 0; + int totalIn = 0; (void)totalIn; char *b = outputBuffer; int result1; diff --git a/groups/bdl/bdlde/bdlde_charconvertutf16.t.cpp b/groups/bdl/bdlde/bdlde_charconvertutf16.t.cpp index 0e105b72be..b5c6c55157 100644 --- a/groups/bdl/bdlde/bdlde_charconvertutf16.t.cpp +++ b/groups/bdl/bdlde/bdlde_charconvertutf16.t.cpp @@ -4,6 +4,8 @@ #include #include +#include + #include #include @@ -2400,6 +2402,7 @@ unsigned char u8FourByteHdrCases[] ={ '\x0', '\x1', '\x2', '\x3', '\x4' }; // value is four, and at that maximum the first continuation octet's // content must be less than 0x10. +BSLA_MAYBE_UNUSED const unsigned char u8InvalidFourByteHdrCases[] ={ '\x5', '\x6', '\x7', }; @@ -2411,19 +2414,23 @@ enum { FOUR_BYTE_FOUR_MAX = 0xf }; // If the first continuation is no greater than this, the content part of // the four-byte header may be two. +BSLA_MAYBE_UNUSED const unsigned char u8ContinByteCases[] ={ '\x0', '\x1', '\x3', '\x7', '\xf', '\x1e', '\x3a', '\x3c', '\x3f', }; +BSLA_MAYBE_UNUSED const unsigned char u8ContinValidFourByteMaxCases[] ={ '\x0', '\x1', '\x3', '\x7', '\xf', }; +BSLA_MAYBE_UNUSED const unsigned char u8ContinInvalidFourByteMaxCases[] ={ '\x10', '\x1e', '\x3c', '\x3a', '\x3f', }; +BSLA_MAYBE_UNUSED const unsigned char u8ReservedRangeLowerContin[] ={ '\x20', '\x21', '\x22', '\x23', '\x24', '\x25', '\x26', '\x27', @@ -2434,6 +2441,7 @@ unsigned char u8ReservedRangeLowerContin[] ={ '\x20', '\x21', '\x22', '\x23', // octet header, these will produce code points in the (forbidden) lower // reserved range. +BSLA_MAYBE_UNUSED const unsigned char u8ReservedRangeUpperContin[] ={ '\x30', '\x31', '\x32', '\x33', '\x34', '\x35', '\x36', '\x37', @@ -2444,6 +2452,7 @@ unsigned char u8ReservedRangeUpperContin[] ={ '\x30', '\x31', '\x32', '\x33', // octet header, these will produce code points in the (forbidden) upper // reserved range. +BSLA_MAYBE_UNUSED const unsigned short u16UpperAndLower[] ={ 0x00, 0x01, 0x02, 0x03, 0x04, 0x06, 0x07, 0x08, 0x0c, 0x0d, 0x10, 0x18, @@ -5491,7 +5500,7 @@ void TestDriver::randomUtf8String(bsl::string *result, // incorrect strings are accurate. int prevErrorIdx = -1; - bool adjacentErrors = false; + bool adjacentErrors = false; (void)adjacentErrors; for (unsigned uu = 0; uu < numSequences; ++uu) { if (s_randGen.bits(1)) { diff --git a/groups/bdl/bdlde/bdlde_quotedprintableencoder.t.cpp b/groups/bdl/bdlde/bdlde_quotedprintableencoder.t.cpp index c7c1dc2a12..45386f3a97 100644 --- a/groups/bdl/bdlde/bdlde_quotedprintableencoder.t.cpp +++ b/groups/bdl/bdlde/bdlde_quotedprintableencoder.t.cpp @@ -2584,7 +2584,7 @@ int main(int argc, char *argv[]) // *** Prepare to process first 'convert' or 'endConvert'. *** int totalOut = 0; - int totalIn = 0; + int totalIn = 0; (void)totalIn; char *b = outputBuffer; int result1; diff --git a/groups/bdl/bdldfp/bdldfp_decimalconvertutil.t.cpp b/groups/bdl/bdldfp/bdldfp_decimalconvertutil.t.cpp index 470e3408aa..f20630588b 100644 --- a/groups/bdl/bdldfp/bdldfp_decimalconvertutil.t.cpp +++ b/groups/bdl/bdldfp/bdldfp_decimalconvertutil.t.cpp @@ -256,10 +256,8 @@ static const float fInf = bsl::numeric_limits::infinity(); static const float fNegInf = -fInf; static const double dInf = bsl::numeric_limits::infinity(); -static const double dNegInf = -dInf; static const long double lInf = bsl::numeric_limits::infinity(); -static const long double lNegInf = -lInf; static const DecBinTestCase DEC2BIN_DATA[] = { diff --git a/groups/bdl/bdlf/bdlf_noop.t.cpp b/groups/bdl/bdlf/bdlf_noop.t.cpp index 62ff46e362..be779eec41 100644 --- a/groups/bdl/bdlf/bdlf_noop.t.cpp +++ b/groups/bdl/bdlf/bdlf_noop.t.cpp @@ -455,8 +455,8 @@ int main(int argc, char *argv[]) if (verbose) cout << "\nMake a copy." << endl; - const Obj X; - Obj mY(X); + const Obj X; + BSLA_MAYBE_UNUSED Obj mY(X); if (verbose) cout << "\nEnsure no memory was allocated." << endl; diff --git a/groups/bdl/bdljsn/bdljsn_json.t.cpp b/groups/bdl/bdljsn/bdljsn_json.t.cpp index d7d8c050b4..46e00765af 100644 --- a/groups/bdl/bdljsn/bdljsn_json.t.cpp +++ b/groups/bdl/bdljsn/bdljsn_json.t.cpp @@ -870,7 +870,7 @@ class ReorderExpectedJsonObjectString { for (int i = 0; i < 4; ++i) { pos = input.find('\"', prev = pos); if (bsl::string::npos == pos) { - ASSERTV(i, input, "Quote character number i not found"); + ASSERTV(i, input, 0 != "Quote character number i not found"); return ""; // RETURN } format[i] = input.substr(prev, pos - prev); @@ -878,20 +878,22 @@ class ReorderExpectedJsonObjectString { const char delim = (i == 3 ? ']' : ','); pos = input.find(delim, prev = pos); if (bsl::string::npos == pos) { - ASSERTV(delim, i, input, "delimiter not found"); + ASSERTV(delim, i, input, 0 != "delimiter not found"); return ""; // RETURN } if (delim == ']') { ++pos; if (pos == input.size()) { - ASSERTV(i, input, "\']\' character was last in string"); + ASSERTV(i, + input, + 0 != "\']\' character was last in string"); return ""; // RETURN } } const bsl::string::size_type secondQuote = input.find('\"', prev + 1); if (secondQuote == bsl::string::npos) { - ASSERTV(i, input, "second quote not found"); + ASSERTV(i, input, 0 != "second quote not found"); return ""; // RETURN } data[input.substr(prev + 1, secondQuote - (prev + 1))] = @@ -5801,6 +5803,9 @@ int main(int argc, char *argv[]) VALUE_CONFIG2, 0 < EXCEPTION_COUNT); } +#else + (void)MEMDST2; + (void)MEMSRC1; #endif } BSLMA_TESTALLOCATOR_EXCEPTION_TEST_END @@ -7256,8 +7261,8 @@ int main(int argc, char *argv[]) bslma::TestAllocator sa("supplied", veryVeryVeryVerbose); Obj mZ(&scratch); - const bool allocated = JsonValueEnumeration::setValue( - &mZ, + BSLA_MAYBE_UNUSED const bool allocated = + JsonValueEnumeration::setValue(&mZ, VALUE_CONFIG); const Obj& Z = mZ; @@ -9658,6 +9663,9 @@ int main(int argc, char *argv[]) if ('N' == MEMDST2 && 'Y' == MEMSRC1) { ASSERTV(LINE1, LINE2, 0 < EXCEPTION_COUNT); } +#else + (void)MEMDST2; + (void)MEMSRC1; #endif } BSLMA_TESTALLOCATOR_EXCEPTION_TEST_END @@ -9962,6 +9970,9 @@ int main(int argc, char *argv[]) if ('N' == MEMDST2 && 'Y' == MEMSRC1) { ASSERTV(LINE1, LINE2, 0 < EXCEPTION_COUNT); } +#else + (void)MEMDST2; + (void)MEMSRC1; #endif } BSLMA_TESTALLOCATOR_EXCEPTION_TEST_END @@ -11065,6 +11076,8 @@ int main(int argc, char *argv[]) if ('Y' == MEM) { ASSERTV(LINE, 0 < EXCEPTION_COUNT); } +#else + (void)MEM; #endif } BSLMA_TESTALLOCATOR_EXCEPTION_TEST_END @@ -13038,6 +13051,9 @@ int main(int argc, char *argv[]) if ('N' == MEMDST2 && 'Y' == MEMSRC1) { ASSERTV(LINE1, LINE2, 0 < EXCEPTION_COUNT); } +#else + (void)MEMDST2; + (void)MEMSRC1; #endif } BSLMA_TESTALLOCATOR_EXCEPTION_TEST_END @@ -13333,6 +13349,9 @@ int main(int argc, char *argv[]) if ('N' == MEMDST2 && 'Y' == MEMSRC1) { ASSERTV(LINE1, LINE2, 0 < EXCEPTION_COUNT); } +#else + (void)MEMDST2; + (void)MEMSRC1; #endif } BSLMA_TESTALLOCATOR_EXCEPTION_TEST_END @@ -14403,6 +14422,8 @@ int main(int argc, char *argv[]) if ('Y' == MEM) { ASSERTV(LINE, 0 < EXCEPTION_COUNT); } +#else + (void)MEM; #endif } BSLMA_TESTALLOCATOR_EXCEPTION_TEST_END diff --git a/groups/bdl/bdljsn/bdljsn_jsontestsuiteutil.t.cpp b/groups/bdl/bdljsn/bdljsn_jsontestsuiteutil.t.cpp index 43221b05d9..b680f99c50 100644 --- a/groups/bdl/bdljsn/bdljsn_jsontestsuiteutil.t.cpp +++ b/groups/bdl/bdljsn/bdljsn_jsontestsuiteutil.t.cpp @@ -388,11 +388,11 @@ int main(int argc, char *argv[]) } break; case 'i': { ASSERTV(EXPECTED, Util::e_EITHER == EXPECTED); } break; - default: { ASSERTV(TEST_NAME[0], !"expected value"); + default: { ASSERTV(TEST_NAME[0], 0 == "expected value"); } break; } } else { - ASSERTV(TEST_NAME, !"well-formed 'TEST_NAME'"); + ASSERTV(TEST_NAME, 0 == "well-formed 'TEST_NAME'"); } bsl::string PATH = testParsingDir + "/" + bsl::string(TEST_NAME); diff --git a/groups/bdl/bdlm/bdlm_metricdescriptor.t.cpp b/groups/bdl/bdlm/bdlm_metricdescriptor.t.cpp index f78da62f42..8317b80419 100644 --- a/groups/bdl/bdlm/bdlm_metricdescriptor.t.cpp +++ b/groups/bdl/bdlm/bdlm_metricdescriptor.t.cpp @@ -586,8 +586,8 @@ int main(int argc, char* argv[]) bslma::DefaultAllocatorGuard dag(&da); - Obj *objPtr; - bslma::TestAllocator *objAllocatorPtr; + Obj *objPtr = 0; + bslma::TestAllocator *objAllocatorPtr = 0; switch (CONFIG) { case 'a': { @@ -603,7 +603,7 @@ int main(int argc, char* argv[]) objAllocatorPtr = &sa; } break; default: { - LOOP_ASSERT(CONFIG, !"Bad allocator config."); + LOOP_ASSERT(CONFIG, 0 == "Bad allocator config."); } break; } LOOP2_ASSERT(LINE, CONFIG, sizeof(Obj) == fa.numBytesInUse()); diff --git a/groups/bdl/bdlm/bdlm_metricsregistry.t.cpp b/groups/bdl/bdlm/bdlm_metricsregistry.t.cpp index 3ea9534fb5..f97c3eb473 100644 --- a/groups/bdl/bdlm/bdlm_metricsregistry.t.cpp +++ b/groups/bdl/bdlm/bdlm_metricsregistry.t.cpp @@ -18,6 +18,7 @@ #include #include +#include #include #include @@ -28,6 +29,12 @@ using namespace BloombergLP; using bsl::cout; using bsl::endl; +#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC +#ifdef BSLS_PLATFORM_CMP_CLANG +#pragma GCC diagnostic ignored "-Wunused-private-field" +#endif +#endif + // ============================================================================ // TEST PLAN // ---------------------------------------------------------------------------- diff --git a/groups/bdl/bdlma/bdlma_blocklist.t.cpp b/groups/bdl/bdlma/bdlma_blocklist.t.cpp index 097d874b8f..5a6e25f997 100644 --- a/groups/bdl/bdlma/bdlma_blocklist.t.cpp +++ b/groups/bdl/bdlma/bdlma_blocklist.t.cpp @@ -739,8 +739,8 @@ int main(int argc, char *argv[]) bslma::DefaultAllocatorGuard dag(&da); - Obj *objPtr; - bslma::TestAllocator *objAllocatorPtr; + Obj *objPtr = 0; + bslma::TestAllocator *objAllocatorPtr = 0; switch (CONFIG) { case 'a': { @@ -756,7 +756,7 @@ int main(int argc, char *argv[]) objAllocatorPtr = &sa; } break; default: { - LOOP_ASSERT(CONFIG, !"Bad allocator config."); + LOOP_ASSERT(CONFIG, 0 == "Bad allocator config."); } break; } LOOP_ASSERT(CONFIG, sizeof(Obj) == fa.numBytesInUse()); diff --git a/groups/bdl/bdlma/bdlma_concurrentfixedpool.t.cpp b/groups/bdl/bdlma/bdlma_concurrentfixedpool.t.cpp index b23eb49242..0950fb47e3 100644 --- a/groups/bdl/bdlma/bdlma_concurrentfixedpool.t.cpp +++ b/groups/bdl/bdlma/bdlma_concurrentfixedpool.t.cpp @@ -37,6 +37,12 @@ using namespace BloombergLP; using namespace bsl; +#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC +#ifdef BSLS_PLATFORM_CMP_CLANG +#pragma GCC diagnostic ignored "-Wunused-private-field" +#endif +#endif + //============================================================================= // STANDARD BDE ASSERT TEST MACRO //----------------------------------------------------------------------------- diff --git a/groups/bdl/bdlma/bdlma_concurrentpool.t.cpp b/groups/bdl/bdlma/bdlma_concurrentpool.t.cpp index 6bb23bd67f..90d3f8cef6 100644 --- a/groups/bdl/bdlma/bdlma_concurrentpool.t.cpp +++ b/groups/bdl/bdlma/bdlma_concurrentpool.t.cpp @@ -29,6 +29,12 @@ using namespace BloombergLP; using namespace bsl; // automatically added by script +#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC +#ifdef BSLS_PLATFORM_CMP_CLANG +#pragma GCC diagnostic ignored "-Wunused-private-field" +#endif +#endif + //============================================================================= // TEST PLAN //----------------------------------------------------------------------------- @@ -1543,7 +1549,7 @@ int main(int argc, char *argv[]) { for (int di = 0; di < NUM_DATA; ++di) { bslma::TestAllocator ta; const bslma::TestAllocator& TA = ta; - bslma::TestAllocator& testAllocator = ta; + bslma::TestAllocator& testAllocator = ta; (void)testAllocator; const int CURRENT_MAX_BLOCKS_PER_CHUNK = DATA[di]; if (veryVerbose) cout << "\t[Starting 'numObjects' : " @@ -1624,7 +1630,7 @@ int main(int argc, char *argv[]) { const int NUM_REPLENISH = 3; bslma::TestAllocator ta; const bslma::TestAllocator& TA = ta; - bslma::TestAllocator& testAllocator = ta; + bslma::TestAllocator& testAllocator = ta; (void)testAllocator; for (int di = 0; di < NUM_DATA; ++di) { BSLMA_TESTALLOCATOR_EXCEPTION_TEST_BEGIN(testAllocator) { diff --git a/groups/bdl/bdlma/bdlma_countingallocator.t.cpp b/groups/bdl/bdlma/bdlma_countingallocator.t.cpp index 43d5a72fff..8f9fddcdee 100644 --- a/groups/bdl/bdlma/bdlma_countingallocator.t.cpp +++ b/groups/bdl/bdlma/bdlma_countingallocator.t.cpp @@ -841,8 +841,8 @@ if (veryVerbose) bslma::DefaultAllocatorGuard dag(&da); - Obj *objPtr; - bslma::TestAllocator *objAllocatorPtr; + Obj *objPtr = 0; + bslma::TestAllocator *objAllocatorPtr = 0; switch (CONFIG) { case 'a': { @@ -858,7 +858,7 @@ if (veryVerbose) objAllocatorPtr = &sa; } break; default: { - LOOP_ASSERT(CONFIG, !"Bad allocator config."); + LOOP_ASSERT(CONFIG, 0 == "Bad allocator config."); } break; } LOOP_ASSERT(CONFIG, sizeof(Obj) == fa.numBytesInUse()); @@ -1310,8 +1310,8 @@ if (veryVerbose) bslma::DefaultAllocatorGuard dag(&da); - Obj *objPtr; - bslma::TestAllocator *objAllocatorPtr; + Obj *objPtr = 0; + bslma::TestAllocator *objAllocatorPtr = 0; switch (CONFIG) { case 'a': { @@ -1327,7 +1327,7 @@ if (veryVerbose) objAllocatorPtr = &sa; } break; default: { - LOOP_ASSERT(CONFIG, !"Bad allocator config."); + LOOP_ASSERT(CONFIG, 0 == "Bad allocator config."); } break; } LOOP_ASSERT(CONFIG, sizeof(Obj) == fa.numBytesInUse()); diff --git a/groups/bdl/bdlma/bdlma_guardingallocator.t.cpp b/groups/bdl/bdlma/bdlma_guardingallocator.t.cpp index 85ab35776c..8e737d27dc 100644 --- a/groups/bdl/bdlma/bdlma_guardingallocator.t.cpp +++ b/groups/bdl/bdlma/bdlma_guardingallocator.t.cpp @@ -1417,7 +1417,7 @@ int main(int argc, char *argv[]) bslma::DefaultAllocatorGuard dag(&da); - Obj *objPtr; + Obj *objPtr = 0; switch (CONFIG) { case 'a': { @@ -1430,7 +1430,7 @@ int main(int argc, char *argv[]) objPtr = new (fa) Obj(Obj::e_BEFORE_USER_BLOCK); } break; default: { - LOOP_ASSERT(CONFIG, !"Bad guard config."); + LOOP_ASSERT(CONFIG, 0 == "Bad guard config."); } break; } LOOP_ASSERT(CONFIG, sizeof(Obj) == fa.numBytesInUse()); diff --git a/groups/bdl/bdlma/bdlma_infrequentdeleteblocklist.t.cpp b/groups/bdl/bdlma/bdlma_infrequentdeleteblocklist.t.cpp index 2d5f7aab02..c0451f9a25 100644 --- a/groups/bdl/bdlma/bdlma_infrequentdeleteblocklist.t.cpp +++ b/groups/bdl/bdlma/bdlma_infrequentdeleteblocklist.t.cpp @@ -773,7 +773,7 @@ int main(int argc, char *argv[]) objAllocatorPtr = &sa; } break; default: { - LOOP_ASSERT(CONFIG, !"Bad allocator config."); + LOOP_ASSERT(CONFIG, 0 == "Bad allocator config."); } break; } LOOP_ASSERT(CONFIG, sizeof(Obj) == fa.numBytesInUse()); diff --git a/groups/bdl/bdlma/bdlma_memoryblockdescriptor.t.cpp b/groups/bdl/bdlma/bdlma_memoryblockdescriptor.t.cpp index 12f636da6a..6d22506fc8 100644 --- a/groups/bdl/bdlma/bdlma_memoryblockdescriptor.t.cpp +++ b/groups/bdl/bdlma/bdlma_memoryblockdescriptor.t.cpp @@ -7,6 +7,7 @@ #include // for testing only #include +#include #include #include @@ -24,6 +25,12 @@ using namespace BloombergLP; using namespace bsl; +#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC +#ifdef BSLS_PLATFORM_CMP_CLANG +#pragma GCC diagnostic ignored "-Wself-assign-overloaded" +#endif +#endif + //============================================================================= // TEST PLAN //----------------------------------------------------------------------------- diff --git a/groups/bdl/bdlma/bdlma_pool.t.cpp b/groups/bdl/bdlma/bdlma_pool.t.cpp index 82f1d4cba9..361f1d5726 100644 --- a/groups/bdl/bdlma/bdlma_pool.t.cpp +++ b/groups/bdl/bdlma/bdlma_pool.t.cpp @@ -27,6 +27,12 @@ using namespace BloombergLP; using namespace bsl; +#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC +#ifdef BSLS_PLATFORM_CMP_CLANG +#pragma GCC diagnostic ignored "-Wunused-private-field" +#endif +#endif + //============================================================================= // TEST PLAN //----------------------------------------------------------------------------- diff --git a/groups/bdl/bdlsb/bdlsb_memoutstreambuf.t.cpp b/groups/bdl/bdlsb/bdlsb_memoutstreambuf.t.cpp index 8aa815c86d..b398dca5e3 100644 --- a/groups/bdl/bdlsb/bdlsb_memoutstreambuf.t.cpp +++ b/groups/bdl/bdlsb/bdlsb_memoutstreambuf.t.cpp @@ -169,13 +169,9 @@ typedef bdlsb::MemOutStreamBuf Obj; const size_t INIT_BUFSIZE = 256; const size_t TWICE_INIT_BUFSIZE = INIT_BUFSIZE * 2; -const size_t INIT_BUFSIZE_PLUS_44 = INIT_BUFSIZE + 44; - // arbitrary number in [1 .. 2k] const size_t INIT_BUFSIZE_MINUS_ONE = INIT_BUFSIZE - 1; const size_t INIT_BUFSIZE_PLUS_ONE = INIT_BUFSIZE + 1; -const size_t TRIPLE_CAPACITY = INIT_BUFSIZE * 3; -const size_t QUADRUPLE_CAPACITY = INIT_BUFSIZE * 4; BSLMF_ASSERT(sizeof(int) <= sizeof(size_t)); diff --git a/groups/bdl/bdlsta/bdlsta_linefit.t.cpp b/groups/bdl/bdlsta/bdlsta_linefit.t.cpp index f8577a4baf..c94990b74b 100644 --- a/groups/bdl/bdlsta/bdlsta_linefit.t.cpp +++ b/groups/bdl/bdlsta/bdlsta_linefit.t.cpp @@ -7,6 +7,7 @@ #include #include +#include #include #include @@ -19,6 +20,12 @@ using namespace BloombergLP; using namespace bsl; +#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC +#ifdef BSLS_PLATFORM_CMP_CLANG +#pragma GCC diagnostic ignored "-Wmissing-braces" +#endif +#endif + // ============================================================================ // TEST PLAN // ---------------------------------------------------------------------------- diff --git a/groups/bdl/bdlsta/bdlsta_moment.t.cpp b/groups/bdl/bdlsta/bdlsta_moment.t.cpp index 7d1c4952ed..cb9370e300 100644 --- a/groups/bdl/bdlsta/bdlsta_moment.t.cpp +++ b/groups/bdl/bdlsta/bdlsta_moment.t.cpp @@ -7,6 +7,7 @@ #include #include +#include #include #include @@ -19,6 +20,12 @@ using namespace BloombergLP; using namespace bsl; +#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC +#ifdef BSLS_PLATFORM_CMP_CLANG +#pragma GCC diagnostic ignored "-Wmissing-braces" +#endif +#endif + // ============================================================================ // TEST PLAN // ---------------------------------------------------------------------------- diff --git a/groups/bdl/bdlt/bdlt_calendar.t.cpp b/groups/bdl/bdlt/bdlt_calendar.t.cpp index f8491aa750..2387358608 100644 --- a/groups/bdl/bdlt/bdlt_calendar.t.cpp +++ b/groups/bdl/bdlt/bdlt_calendar.t.cpp @@ -19,6 +19,7 @@ #include #include +#include #include #include @@ -41,6 +42,12 @@ using namespace BloombergLP; using namespace bsl; +#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC +#ifdef BSLS_PLATFORM_CMP_CLANG +#pragma GCC diagnostic ignored "-Wunused-private-field" +#endif +#endif + // ============================================================================ // TEST PLAN // ---------------------------------------------------------------------------- @@ -5469,7 +5476,7 @@ int main(int argc, char *argv[]) int LENGTH = 0; int NUM_NONBUSINESSDAY = 0; int NUM_WEEKENDDAY = 0; - int NUM_HOLIDAYCODES = 0; + int NUM_HOLIDAYCODES = 0; (void)NUM_HOLIDAYCODES; bdlt::Date date; bool notDone; @@ -7224,8 +7231,8 @@ int main(int argc, char *argv[]) bslma::DefaultAllocatorGuard dag(&da); - Obj *objPtr; - bslma::TestAllocator *objAllocatorPtr; + Obj *objPtr = 0; + bslma::TestAllocator *objAllocatorPtr = 0; switch (CONFIG) { case 'a': { @@ -7241,7 +7248,7 @@ int main(int argc, char *argv[]) objAllocatorPtr = &sa; } break; default: { - LOOP_ASSERT(CONFIG, !"Bad allocator config."); + LOOP_ASSERT(CONFIG, 0 == "Bad allocator config."); } break; } LOOP2_ASSERT(ti, CONFIG, diff --git a/groups/bdl/bdlt/bdlt_calendarcache.t.cpp b/groups/bdl/bdlt/bdlt_calendarcache.t.cpp index 022fe5dd05..da525a30b2 100644 --- a/groups/bdl/bdlt/bdlt_calendarcache.t.cpp +++ b/groups/bdl/bdlt/bdlt_calendarcache.t.cpp @@ -10,6 +10,8 @@ #include +#include + #include #include #include @@ -723,11 +725,11 @@ int MyCalendarLoader::load(bdlt::PackedCalendar *result, int main(int argc, char *argv[]) { - int test = argc > 1 ? atoi(argv[1]) : 0; - bool verbose = argc > 2; - bool veryVerbose = argc > 3; - bool veryVeryVerbose = argc > 4; - bool veryVeryVeryVerbose = argc > 5; + BSLA_MAYBE_UNUSED int test = argc > 1 ? atoi(argv[1]) : 0; + BSLA_MAYBE_UNUSED bool verbose = argc > 2; + BSLA_MAYBE_UNUSED bool veryVerbose = argc > 3; + BSLA_MAYBE_UNUSED bool veryVeryVerbose = argc > 4; + BSLA_MAYBE_UNUSED bool veryVeryVeryVerbose = argc > 5; cout << "TEST " << __FILE__ << " CASE " << test << endl; @@ -1864,8 +1866,8 @@ int main(int argc, char *argv[]) bslma::DefaultAllocatorGuard dag(&da); - Obj *objPtr; - bslma::TestAllocator *objAllocatorPtr; + Obj *objPtr = 0; + bslma::TestAllocator *objAllocatorPtr = 0; switch (CONFIG) { case 'a': { @@ -1881,7 +1883,7 @@ int main(int argc, char *argv[]) objAllocatorPtr = &sa; } break; default: { - LOOP_ASSERT(CONFIG, !"Bad allocator config."); + LOOP_ASSERT(CONFIG, 0 == "Bad allocator config."); } break; } @@ -1957,8 +1959,8 @@ int main(int argc, char *argv[]) bslma::DefaultAllocatorGuard dag(&da); - Obj *objPtr; - bslma::TestAllocator *objAllocatorPtr; + Obj *objPtr = 0; + bslma::TestAllocator *objAllocatorPtr = 0; switch (CONFIG) { case 'a': { @@ -1974,7 +1976,7 @@ int main(int argc, char *argv[]) objAllocatorPtr = &sa; } break; default: { - LOOP_ASSERT(CONFIG, !"Bad allocator config."); + LOOP_ASSERT(CONFIG, 0 == "Bad allocator config."); } break; } diff --git a/groups/bdl/bdlt/bdlt_datetime.t.cpp b/groups/bdl/bdlt/bdlt_datetime.t.cpp index 4d67ded9c0..a01d56a8bb 100644 --- a/groups/bdl/bdlt/bdlt_datetime.t.cpp +++ b/groups/bdl/bdlt/bdlt_datetime.t.cpp @@ -2214,8 +2214,9 @@ int main(int argc, char *argv[]) //.. // Finally, we stream the value of 'dt2' to 'stdout': //.. -if (veryVerbose) +if (veryVerbose) { bsl::cout << dt2 << bsl::endl; +} //.. // The streaming operator produces the following output on 'stdout': //.. diff --git a/groups/bdl/bdlt/bdlt_dayofweekset.t.cpp b/groups/bdl/bdlt/bdlt_dayofweekset.t.cpp index b8941e4b80..473b4498e9 100644 --- a/groups/bdl/bdlt/bdlt_dayofweekset.t.cpp +++ b/groups/bdl/bdlt/bdlt_dayofweekset.t.cpp @@ -37,6 +37,12 @@ using bsl::cerr; using bsl::endl; using bsl::flush; +#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC +#ifdef BSLS_PLATFORM_CMP_CLANG +#pragma GCC diagnostic ignored "-Wself-assign-overloaded" +#endif +#endif + // ============================================================================ // TEST PLAN // ---------------------------------------------------------------------------- diff --git a/groups/bdl/bdlt/bdlt_fixutil.t.cpp b/groups/bdl/bdlt/bdlt_fixutil.t.cpp index 46de5ca37e..de7fab7e56 100644 --- a/groups/bdl/bdlt/bdlt_fixutil.t.cpp +++ b/groups/bdl/bdlt/bdlt_fixutil.t.cpp @@ -1238,8 +1238,9 @@ int main(int argc, char *argv[]) // For comparison with the FIX string generated below, note that streaming the // value of 'sourceDatetimeTz' to 'stdout': //.. -if (veryVerbose) +if (veryVerbose) { bsl::cout << sourceDatetimeTz << bsl::endl; +} //.. // produces: //.. diff --git a/groups/bdl/bdlt/bdlt_iso8601util.00.t.cpp b/groups/bdl/bdlt/bdlt_iso8601util.00.t.cpp index ef3f083d97..b03f11e4c6 100644 --- a/groups/bdl/bdlt/bdlt_iso8601util.00.t.cpp +++ b/groups/bdl/bdlt/bdlt_iso8601util.00.t.cpp @@ -93,6 +93,8 @@ Sun_Studio_only_gives_a_warning_for_pound_error; #include +#include + #include #include @@ -7098,8 +7100,9 @@ int main(int argc, char *argv[]) // For comparison with the ISO 8601 string generated below, note that streaming // the value of 'sourceDatetimeTz' to 'stdout': //.. -if (veryVerbose) +if (veryVerbose) { bsl::cout << sourceDatetimeTz << bsl::endl; +} //.. // produces: //.. @@ -7164,8 +7167,9 @@ if (veryVerbose) // For comparison with the ISO 8601 string generated below, note that streaming // the value of 'sourceTimeTz' to 'stdout': //.. -if (veryVerbose) +if (veryVerbose) { bsl::cout << sourceTimeTz << bsl::endl; +} //.. // produces: //.. @@ -12814,8 +12818,8 @@ if (veryVerbose) const char *INPUT = "20131023T012345"; const ptrdiff_t LENGTH = bsl::strlen(INPUT); - const StrView stringRef(INPUT, LENGTH); - const StrView nullRef; + const StrView stringRef(INPUT, LENGTH); + BSLA_MAYBE_UNUSED const StrView nullRef; bdlt::Datetime result; bdlt::DatetimeTz resultTz; diff --git a/groups/bdl/bdlt/bdlt_packedcalendar.t.cpp b/groups/bdl/bdlt/bdlt_packedcalendar.t.cpp index a20fcb6b62..ec1fe6b3a5 100644 --- a/groups/bdl/bdlt/bdlt_packedcalendar.t.cpp +++ b/groups/bdl/bdlt/bdlt_packedcalendar.t.cpp @@ -4713,7 +4713,7 @@ int main(int argc, char *argv[]) int LENGTH = 0; int NUM_NONBUSINESSDAY = 0; int NUM_WEEKENDDAY = 0; - int NUM_HOLIDAYCODES = 0; + int NUM_HOLIDAYCODES = 0; (void)NUM_HOLIDAYCODES; bdlt::Date date; bool notDone; @@ -6412,8 +6412,8 @@ int main(int argc, char *argv[]) bslma::DefaultAllocatorGuard dag(&da); - Obj *objPtr; - bslma::TestAllocator *objAllocatorPtr; + Obj *objPtr = 0; + bslma::TestAllocator *objAllocatorPtr = 0; switch (CONFIG) { case 'a': { @@ -6429,7 +6429,7 @@ int main(int argc, char *argv[]) objAllocatorPtr = &sa; } break; default: { - LOOP_ASSERT(CONFIG, !"Bad allocator config."); + LOOP_ASSERT(CONFIG, 0 == "Bad allocator config."); } break; } LOOP2_ASSERT(ti, CONFIG, diff --git a/groups/bdl/bdlt/bdlt_timetable.t.cpp b/groups/bdl/bdlt/bdlt_timetable.t.cpp index 0353d518f1..500689d8c1 100644 --- a/groups/bdl/bdlt/bdlt_timetable.t.cpp +++ b/groups/bdl/bdlt/bdlt_timetable.t.cpp @@ -2539,8 +2539,8 @@ int main(int argc, char *argv[]) bslma::DefaultAllocatorGuard dag(&da); - Obj *objPtr; - bslma::TestAllocator *objAllocatorPtr; + Obj *objPtr = 0; + bslma::TestAllocator *objAllocatorPtr = 0; switch (CONFIG) { case 'a': { @@ -2556,7 +2556,7 @@ int main(int argc, char *argv[]) objAllocatorPtr = &sa; } break; default: { - LOOP_ASSERT(CONFIG, !"Bad allocator config."); + LOOP_ASSERT(CONFIG, 0 == "Bad allocator config."); } break; } LOOP2_ASSERT(ti, CONFIG, diff --git a/groups/bdl/bdlt/bdlt_timetablecache.t.cpp b/groups/bdl/bdlt/bdlt_timetablecache.t.cpp index 7d1358e912..d2d6932ee1 100644 --- a/groups/bdl/bdlt/bdlt_timetablecache.t.cpp +++ b/groups/bdl/bdlt/bdlt_timetablecache.t.cpp @@ -8,6 +8,8 @@ #include #include +#include + #include #include @@ -722,11 +724,11 @@ int MyTimetableLoader::load(bdlt::Timetable *result, const char *timetableName) int main(int argc, char *argv[]) { - int test = argc > 1 ? atoi(argv[1]) : 0; - bool verbose = argc > 2; - bool veryVerbose = argc > 3; - bool veryVeryVerbose = argc > 4; - bool veryVeryVeryVerbose = argc > 5; + BSLA_MAYBE_UNUSED int test = argc > 1 ? atoi(argv[1]) : 0; + BSLA_MAYBE_UNUSED bool verbose = argc > 2; + BSLA_MAYBE_UNUSED bool veryVerbose = argc > 3; + BSLA_MAYBE_UNUSED bool veryVeryVerbose = argc > 4; + BSLA_MAYBE_UNUSED bool veryVeryVeryVerbose = argc > 5; cout << "TEST " << __FILE__ << " CASE " << test << endl; @@ -1849,8 +1851,8 @@ int main(int argc, char *argv[]) bslma::DefaultAllocatorGuard dag(&da); - Obj *objPtr; - bslma::TestAllocator *objAllocatorPtr; + Obj *objPtr = 0; + bslma::TestAllocator *objAllocatorPtr = 0; switch (CONFIG) { case 'a': { @@ -1866,7 +1868,7 @@ int main(int argc, char *argv[]) objAllocatorPtr = &sa; } break; default: { - LOOP_ASSERT(CONFIG, !"Bad allocator config."); + LOOP_ASSERT(CONFIG, 0 == "Bad allocator config."); } break; } @@ -1942,8 +1944,8 @@ int main(int argc, char *argv[]) bslma::DefaultAllocatorGuard dag(&da); - Obj *objPtr; - bslma::TestAllocator *objAllocatorPtr; + Obj *objPtr = 0; + bslma::TestAllocator *objAllocatorPtr = 0; switch (CONFIG) { case 'a': { @@ -1959,7 +1961,7 @@ int main(int argc, char *argv[]) objAllocatorPtr = &sa; } break; default: { - LOOP_ASSERT(CONFIG, !"Bad allocator config."); + LOOP_ASSERT(CONFIG, 0 == "Bad allocator config."); } break; } diff --git a/groups/bdl/bdlt/bdlt_timetz.t.cpp b/groups/bdl/bdlt/bdlt_timetz.t.cpp index 17f73923c8..e7c9436a89 100644 --- a/groups/bdl/bdlt/bdlt_timetz.t.cpp +++ b/groups/bdl/bdlt/bdlt_timetz.t.cpp @@ -9,6 +9,7 @@ #include #include +#include #include #include @@ -30,6 +31,12 @@ using namespace BloombergLP; using namespace bsl; +#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC +#ifdef BSLS_PLATFORM_CMP_CLANG +#pragma GCC diagnostic ignored "-Wself-assign-overloaded" +#endif +#endif + // ============================================================================ // TEST PLAN // ---------------------------------------------------------------------------- diff --git a/groups/bdl/bdlt/bdlt_timeutil.t.cpp b/groups/bdl/bdlt/bdlt_timeutil.t.cpp index baf03f251e..0c3e52f705 100644 --- a/groups/bdl/bdlt/bdlt_timeutil.t.cpp +++ b/groups/bdl/bdlt/bdlt_timeutil.t.cpp @@ -152,8 +152,9 @@ if (verbose) bsl::cout << "\nUsage Example 1" << endl; bdlt::Time result = bdlt::TimeUtil::convertFromHHMMSSmmm(timeValue); -if (veryVerbose) +if (veryVerbose) { bsl::cout << result << bsl::endl; +} //.. // The code above produces the following on 'stdout': //..