Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop returning datetimes with pytz timezones #86

Open
godlygeek opened this issue Jan 28, 2025 · 1 comment
Open

Stop returning datetimes with pytz timezones #86

godlygeek opened this issue Jan 28, 2025 · 1 comment

Comments

@godlygeek
Copy link
Contributor

godlygeek commented Jan 28, 2025 •
edited
Loading

Leverage pytz-deprecation-shim to break our dependency on pytz but minimize user disruption. We've held off on this for a long time due to the risk of breaking end user code that's relying on the timezone objects that we return being specifically pytz timezone instances, but after spending hours today tracking down a bug that turned out to be caused by pytz using local solar mean time instead of the correct UTC offset for any timestamp before December 13th 1901, I think it's time to concede that leaving the pytz dependency in place is causing more problems than removing it will.
@godlygeek
Copy link
Contributor Author 

$ date -d "1970-01-01 - 2147483647 seconds"
Fri Dec 13 20:45:53 EST 1901

🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@godlygeek