Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example of Instruction table override #1891

Open
rakita opened this issue Dec 5, 2024 · 5 comments · May be fixed by #2031
Open

Example of Instruction table override #1891

rakita opened this issue Dec 5, 2024 · 5 comments · May be fixed by #2031
Labels
good first issue Good for newcomers

Comments

@rakita
Copy link
Member

rakita commented Dec 5, 2024

An example of this needs to be worked out and an appropriate helper function should be added (if needed).

@rakita rakita added the good first issue Good for newcomers label Dec 5, 2024
@FredCoen
Copy link
Contributor

i'm gonna try this this weekend!

@FredCoen
Copy link
Contributor

@rakita currently there is an "examples/custom_opcodes" which is not working since the refactors. But the idea is to do something similar right?

To make it more fun can I make it execute something instead of just compiling the lib for demonstration purposes?

@rakita
Copy link
Member Author

rakita commented Jan 27, 2025

@FredCoen i have some refactor that i need to do and move instructions inside Context and make it easier to modify. Plan was to update that example after this.

This is highest priorities that i will work next as it is needed for Reth integration and REVM Framework.

@FredCoen
Copy link
Contributor

broke the "last factor" already after a week hehe :))

cool i got it half implemented, added a clz opcode. will update it once you refactored. Dont think the opcode implementation itself should change

@rakita
Copy link
Member Author

rakita commented Jan 28, 2025

All for good code! But it is closing, have a tracking task #2027

@FredCoen FredCoen linked a pull request Jan 28, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants