Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should provide safer examples for custom type converters #127

Open
kcoppock opened this issue Dec 14, 2015 · 0 comments
Open

Should provide safer examples for custom type converters #127

kcoppock opened this issue Dec 14, 2015 · 0 comments

Comments

@kcoppock
Copy link

On the documentation for custom types:

https://github.com/bluelinelabs/LoganSquare/blob/master/docs/TypeConverters.md

It mentions using TestEnum.values()[index] or TestEnum.valueOf(string) to do the conversion. However, these can both cause uncaught exceptions (ArrayIndexOutOfBounds for the index lookup, IllegalArgumentException for the String lookup) if the values on the remote service ever change; for example, if a new value is added, but an older client doesn't have an enum value for it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant