Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit work done in @atproto/sync when handling empty commit parsing #2900

Open
dholms opened this issue Oct 20, 2024 · 0 comments
Open

Limit work done in @atproto/sync when handling empty commit parsing #2900

dholms opened this issue Oct 20, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@dholms
Copy link
Collaborator

dholms commented Oct 20, 2024

We should bail out of parseCommitAuthenticated in the Firehose when processing an event with no ops - or no ops that we're interested in after filtering.

This causes irrelevant errors to surface while parsing firehose: https://bsky.app/profile/robertlin.bsky.social/post/3l6tbxtorns2w
@dholms dholms added the bug Something isn't working label Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dholms