Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NormaliseUriHandler conflicts with BasePathHandler #2

Closed
spmiller opened this issue Nov 20, 2014 · 2 comments
Closed

NormaliseUriHandler conflicts with BasePathHandler #2

spmiller opened this issue Nov 20, 2014 · 2 comments

Comments

@spmiller
Copy link
Member

When both the NormaliseUriHandler and the BasePathHandler are used (they are both enabled by default), the BasePathHandler fails to work correctly.

Let's say the BasePath is set to /foo/. The BasePathHandler is meant to remove /foo/ from all requests so you don't have to specify the whole path in the resource -- eg, /foo/bar will be converted to just bar.

The NormaliseUriHandler kicks in beforehand though, and will change any request to /foo/ to be /foo, which obviously doesn't match the BasePath.

This is an edge case, but it's quite annoying for the first request!

Pull Request #1 includes a failing test for this issue.

@danielbodart
Copy link
Member

Stu did I fix this already?

@spmiller
Copy link
Member Author

Yep, I think so!

On Tue, Jan 27, 2015 at 1:44 PM, Daniel Worthington-Bodart <
[email protected]> wrote:

Stu did I fix this already?


Reply to this email directly or view it on GitHub
#2 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants