Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build error: execution_monitor.ipp: error: expected ')' before 'PRIxPTR' #436

Closed
barracuda156 opened this issue Jan 17, 2025 · 6 comments · Fixed by #437 or #438
Closed

Build error: execution_monitor.ipp: error: expected ')' before 'PRIxPTR' #436

barracuda156 opened this issue Jan 17, 2025 · 6 comments · Fixed by #437 or #438

Comments

@barracuda156
Copy link
Contributor

The following header has an inaccurate condition to define __STDC_FORMAT_MACROS:

test/include/boost/test/impl/execution_monitor.ipp

Lines 197 to 212 in fcd634a

#if (!defined(BOOST_MSSTL_VERSION) || (BOOST_MSSTL_VERSION >= 120)) && (!defined(__GLIBC__) || ((__GLIBC__ > 2) || ((__GLIBC__ == 2) && (__GLIBC_MINOR__ >= 2))))
// glibc 2.2 - 2.17 required __STDC_FORMAT_MACROS to be defined for use of PRIxPTR
# if defined(__GLIBC__) && !((__GLIBC__ > 2) || ((__GLIBC__ == 2) && (__GLIBC_MINOR__ >= 18)))
# ifndef __STDC_FORMAT_MACROS
# define __STDC_FORMAT_MACROS 1
# define BOOST_TEST_DEFINED_STDC_FORMAT_MACROS
# endif
# endif
# include <inttypes.h>
# define BOOST_TEST_PRIxPTR PRIxPTR
# ifdef BOOST_TEST_DEFINED_STDC_FORMAT_MACROS
# undef __STDC_FORMAT_MACROS
# endif
#else
# define BOOST_TEST_PRIxPTR "08lx"
#endif

So I get this failure on macOS, for example:

:info:build ./boost/test/impl/execution_monitor.ipp:444:25: note: to match this '('
:info:build   444 |             report_error( execution_exception::system_fatal_error,
:info:build       |                         ^
:info:build ./boost/test/impl/execution_monitor.ipp:215:1: note: 'PRIxPTR' is defined in header '<cinttypes>'; this is probably fixable by adding '#include <cinttypes>'
:info:build   214 | #include <boost/test/detail/suppress_warnings.hpp>
:info:build   +++ |+#include <cinttypes>
:info:build   215 | 
:info:build ./boost/test/impl/execution_monitor.ipp:445:86: warning: spurious trailing '%' in format [-Wformat=]
:info:build   445 |                           "signal: illegal opcode; address of failing instruction: 0x%" BOOST_TEST_PRIxPTR,
:info:build       |                                                                                      ^
:info:build ./boost/test/impl/execution_monitor.ipp:445:27: warning: too many arguments for format [-Wformat-extra-args]
:info:build   445 |                           "signal: illegal opcode; address of failing instruction: 0x%" BOOST_TEST_PRIxPTR,
:info:build       |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
:info:build ./boost/test/impl/execution_monitor.ipp:450:86: error: expected ')' before 'PRIxPTR'
:info:build   450 |                           "signal: illegal trap; address of failing instruction: 0x%" BOOST_TEST_PRIxPTR,
:info:build       |                                                                                      ^
:info:build       |                                                                                      )
:info:build ./boost/test/impl/execution_monitor.ipp:449:25: note: to match this '('
:info:build   449 |             report_error( execution_exception::system_fatal_error,
:info:build       |                         ^
:info:build ./boost/test/impl/execution_monitor.ipp:206:30: note: 'PRIxPTR' is defined in header '<cinttypes>'; this is probably fixable by adding '#include <cinttypes>'
:info:build   206 | #  define BOOST_TEST_PRIxPTR PRIxPTR
:info:build       |                              ^~~~~~~
:info:build ./boost/test/impl/execution_monitor.ipp:450:87: note: in expansion of macro 'BOOST_TEST_PRIxPTR'
:info:build   450 |                           "signal: illegal trap; address of failing instruction: 0x%" BOOST_TEST_PRIxPTR,
:info:build       |                                                                                       ^~~~~~~~~~~~~~~~~~
:info:build ./boost/test/impl/execution_monitor.ipp:450:84: warning: spurious trailing '%' in format [-Wformat=]
:info:build   450 |                           "signal: illegal trap; address of failing instruction: 0x%" BOOST_TEST_PRIxPTR,
:info:build       |                                                                                    ^
:info:build ./boost/test/impl/execution_monitor.ipp:450:27: warning: too many arguments for format [-Wformat-extra-args]
:info:build   450 |                           "signal: illegal trap; address of failing instruction: 0x%" BOOST_TEST_PRIxPTR,
:info:build       |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
:info:build ./boost/test/impl/execution_monitor.ipp:455:93: error: expected ')' before 'PRIxPTR'
:info:build   455 |                           "signal: privileged register; address of failing instruction: 0x%" BOOST_TEST_PRIxPTR,
:info:build       |                                                                                             ^
:info:build       |                                                                                             )
:info:build ./boost/test/impl/execution_monitor.ipp:454:25: note: to match this '('
:info:build   454 |             report_error( execution_exception::system_fatal_error,
:info:build       |                         ^
:info:build ./boost/test/impl/execution_monitor.ipp:206:30: note: 'PRIxPTR' is defined in header '<cinttypes>'; this is probably fixable by adding '#include <cinttypes>'
:info:build   206 | #  define BOOST_TEST_PRIxPTR PRIxPTR
:info:build       |                              ^~~~~~~
:info:build ./boost/test/impl/execution_monitor.ipp:455:94: note: in expansion of macro 'BOOST_TEST_PRIxPTR'
:info:build   455 |                           "signal: privileged register; address of failing instruction: 0x%" BOOST_TEST_PRIxPTR,
:info:build       |                                                                                              ^~~~~~~~~~~~~~~~~~
:info:build ./boost/test/impl/execution_monitor.ipp:455:91: warning: spurious trailing '%' in format [-Wformat=]
:info:build   455 |                           "signal: privileged register; address of failing instruction: 0x%" BOOST_TEST_PRIxPTR,
:info:build       |                                                                                           ^
:info:build ./boost/test/impl/execution_monitor.ipp:455:27: warning: too many arguments for format [-Wformat-extra-args]
:info:build   455 |                           "signal: privileged register; address of failing instruction: 0x%" BOOST_TEST_PRIxPTR,
:info:build       |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
:info:build ./boost/test/impl/execution_monitor.ipp:460:94: error: expected ')' before 'PRIxPTR'
:info:build   460 |                           "signal: internal stack error; address of failing instruction: 0x%" BOOST_TEST_PRIxPTR,
:info:build       |                                                                                              ^
:info:build       |                                                                                              )
:info:build ./boost/test/impl/execution_monitor.ipp:459:25: note: to match this '('
:info:build   459 |             report_error( execution_exception::system_fatal_error,
:info:build       |                         ^
:info:build ./boost/test/impl/execution_monitor.ipp:206:30: note: 'PRIxPTR' is defined in header '<cinttypes>'; this is probably fixable by adding '#include <cinttypes>'
:info:build   206 | #  define BOOST_TEST_PRIxPTR PRIxPTR
:info:build       |                              ^~~~~~~
:info:build ./boost/test/impl/execution_monitor.ipp:460:95: note: in expansion of macro 'BOOST_TEST_PRIxPTR'
:info:build   460 |                           "signal: internal stack error; address of failing instruction: 0x%" BOOST_TEST_PRIxPTR,
:info:build       |                                                                                               ^~~~~~~~~~~~~~~~~~
:info:build ./boost/test/impl/execution_monitor.ipp:460:92: warning: spurious trailing '%' in format [-Wformat=]
:info:build   460 |                           "signal: internal stack error; address of failing instruction: 0x%" BOOST_TEST_PRIxPTR,
:info:build       |                                                                                            ^
:info:build ./boost/test/impl/execution_monitor.ipp:460:27: warning: too many arguments for format [-Wformat-extra-args]
:info:build   460 |                           "signal: internal stack error; address of failing instruction: 0x%" BOOST_TEST_PRIxPTR,
:info:build       |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
:info:build ./boost/test/impl/execution_monitor.ipp:466:89: error: expected ')' before 'PRIxPTR'
:info:build   466 |                           "signal: illegal operand; address of failing instruction: 0x%" BOOST_TEST_PRIxPTR,
:info:build       |                                                                                         ^
:info:build       |                                                                                         )
:info:build ./boost/test/impl/execution_monitor.ipp:465:25: note: to match this '('
:info:build   465 |             report_error( execution_exception::system_fatal_error,
:info:build       |                         ^
:info:build ./boost/test/impl/execution_monitor.ipp:206:30: note: 'PRIxPTR' is defined in header '<cinttypes>'; this is probably fixable by adding '#include <cinttypes>'
:info:build   206 | #  define BOOST_TEST_PRIxPTR PRIxPTR
:info:build       |                              ^~~~~~~
:info:build ./boost/test/impl/execution_monitor.ipp:466:90: note: in expansion of macro 'BOOST_TEST_PRIxPTR'
:info:build   466 |                           "signal: illegal operand; address of failing instruction: 0x%" BOOST_TEST_PRIxPTR,
:info:build       |                                                                                          ^~~~~~~~~~~~~~~~~~
:info:build ./boost/test/impl/execution_monitor.ipp:466:87: warning: spurious trailing '%' in format [-Wformat=]
:info:build   466 |                           "signal: illegal operand; address of failing instruction: 0x%" BOOST_TEST_PRIxPTR,
:info:build       |                                                                                       ^
:info:build ./boost/test/impl/execution_monitor.ipp:466:27: warning: too many arguments for format [-Wformat-extra-args]
:info:build   466 |                           "signal: illegal operand; address of failing instruction: 0x%" BOOST_TEST_PRIxPTR,
:info:build       |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
:info:build ./boost/test/impl/execution_monitor.ipp:471:97: error: expected ')' before 'PRIxPTR'
:info:build   471 |                           "signal: illegal addressing mode; address of failing instruction: 0x%" BOOST_TEST_PRIxPTR,
:info:build       |                                                                                                 ^
:info:build       |                                                                                                 )
:info:build ./boost/test/impl/execution_monitor.ipp:470:25: note: to match this '('
:info:build   470 |             report_error( execution_exception::system_fatal_error,
:info:build       |                         ^
:info:build ./boost/test/impl/execution_monitor.ipp:206:30: note: 'PRIxPTR' is defined in header '<cinttypes>'; this is probably fixable by adding '#include <cinttypes>'
:info:build   206 | #  define BOOST_TEST_PRIxPTR PRIxPTR
:info:build       |                              ^~~~~~~
:info:build ./boost/test/impl/execution_monitor.ipp:471:98: note: in expansion of macro 'BOOST_TEST_PRIxPTR'
:info:build   471 |                           "signal: illegal addressing mode; address of failing instruction: 0x%" BOOST_TEST_PRIxPTR,
:info:build       |                                                                                                  ^~~~~~~~~~~~~~~~~~
:info:build ./boost/test/impl/execution_monitor.ipp:471:95: warning: spurious trailing '%' in format [-Wformat=]
:info:build   471 |                           "signal: illegal addressing mode; address of failing instruction: 0x%" BOOST_TEST_PRIxPTR,
:info:build       |                                                                                               ^
:info:build ./boost/test/impl/execution_monitor.ipp:471:27: warning: too many arguments for format [-Wformat-extra-args]
:info:build   471 |                           "signal: illegal addressing mode; address of failing instruction: 0x%" BOOST_TEST_PRIxPTR,
:info:build       |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
:info:build ./boost/test/impl/execution_monitor.ipp:476:91: error: expected ')' before 'PRIxPTR'
:info:build   476 |                           "signal: privileged opcode; address of failing instruction: 0x%" BOOST_TEST_PRIxPTR,
:info:build       |                                                                                           ^
:info:build       |

It should not be restricted to Linux, other systems may also need __STDC_FORMAT_MACROS before including inttypes.h.
@tjanas
Copy link

tjanas commented Jan 22, 2025

Since execution_monitor.ipp includes other c++ headers (like <cstring> instead of <string.h>), is there a reason why the include is for <inttypes.h> instead of <cinttypes>?

@tjanas
Copy link

tjanas commented Jan 22, 2025 •
edited
Loading

On a related note, can someone add a patch link to https://www.boost.org/users/history/version_1_83_0.html for this issue that was fixed in linux via cada8c1 ?

--- a/boost_1_83_0/boost/test/impl/execution_monitor.ipp
+++ b/boost_1_83_0/boost/test/impl/execution_monitor.ipp
@@ -194,9 +194,19 @@ namespace { void _set_se_translator( void* ) {} }
 #  include <boost/core/demangle.hpp>
 #endif

-#if !defined(BOOST_MSSTL_VERSION) || (BOOST_MSSTL_VERSION >= 120)
+#if (!defined(BOOST_MSSTL_VERSION) || (BOOST_MSSTL_VERSION >= 120)) && (!defined(__GLIBC__) || ((__GLIBC__ > 2) || ((__GLIBC__ == 2) && (__GLIBC_MINOR__ >= 2))))
+// glibc 2.2 - 2.17 required __STDC_FORMAT_MACROS to be defined for use of PRIxPTR
+#  if defined(__GLIBC__) && !((__GLIBC__ > 2) || ((__GLIBC__ == 2) && (__GLIBC_MINOR__ >= 18)))
+#    ifndef __STDC_FORMAT_MACROS
+#      define __STDC_FORMAT_MACROS 1
+#      define BOOST_TEST_DEFINED_STDC_FORMAT_MACROS
+#    endif
+#  endif
 #  include <inttypes.h>
 #  define BOOST_TEST_PRIxPTR PRIxPTR
+#  ifdef BOOST_TEST_DEFINED_STDC_FORMAT_MACROS
+#    undef __STDC_FORMAT_MACROS
+#  endif
 #else
 #  define BOOST_TEST_PRIxPTR "08lx"
 #endif

@mborland
Copy link
Member

Since execution_monitor.ipp includes other c++ headers (like <cstring> instead of <string.h>), is there a reason why the include is for <inttypes.h> instead of <cinttypes>?

Compatibility with really old toolchains.

@barracuda156
Copy link
Contributor Author

Since execution_monitor.ipp includes other c++ headers (like <cstring> instead of <string.h>), is there a reason why the include is for <inttypes.h> instead of <cinttypes>?

Changing the header to cinttypes does not solve the problem of incorrect condition for __STDC_FORMAT_MACROS in a general case. It will fix the breakage for some compilers, but not for others.

@mborland mborland mentioned this issue Jan 22, 2025
Merged
@mborland
Copy link
Member

Since execution_monitor.ipp includes other c++ headers (like <cstring> instead of <string.h>), is there a reason why the include is for <inttypes.h> instead of <cinttypes>?

Changing the header to cinttypes does not solve the problem of incorrect condition for __STDC_FORMAT_MACROS in a general case. It will fix the breakage for some compilers, but not for others.

Correct. I think #437 should solve the remaining cases like this one on newer toolchains.

@barracuda156
Copy link
Contributor Author

@mborland Sorry, this does not work correctly. The issue is that the first macro evaluates as true on macOS, so inttypes.h is includes, but the macro for __STDC_FORMAT_MACROS is unnecessarily Linux-only, so we get exactly the same error as before: the added fallback is never used.

barracuda156 added a commit to barracuda156/test that referenced this issue Jan 26, 2025
@barracuda156
execution_monitor.ipp: follow-up fix for macOS
d19ff0b 
This fixes boostorg#436
@barracuda156 barracuda156 mentioned this issue Jan 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mborland @tjanas @barracuda156