Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SENinja dock widgets are not visible or accessible in Binary Ninja 4.0 #14

Open
galenbwill opened this issue Feb 13, 2024 · 6 comments
Open

Comments

@galenbwill
Copy link

galenbwill commented Feb 13, 2024

Dock widgets have been deprecated in the Binary Ninja UI, and it appears the SENinja UI elements cannot be made visible in the new 4.0 interface currently on the dev channel.

The dock widgets probably need to be converted into sidebar widgets.

(Tested on both version installed from Plugin Manager and current master on github.)

Also, this one floating thing does appear, and can be moved around the screen, but it's not clear if it's an SENinja dock widget or something else:

Edit: it appears that little floating thing in the screenshot is not coming from this plugin, so I've deleted the screenshot.

@borzacchiello
Copy link
Owner

Thank you for pointing out the issue!

It'll take a while, but I'll work on it :)

@galenbwill
Copy link
Author

Also note that the "SENinja Memory" widget does show up in the global area as it should, but with the new sidebar UI it appears in the "Other (Compatibility)" pane, accessible via the question mark sidebar button (bottom left by default, I believe).

@robert-yates
Copy link
Contributor

i was thinking a while ago to convert this into sidebar stuff, but i kind of liked it on the right side rather than left, however now with 4.0 there will be a lot more good options, but im more a c++ coder than python, so i will leave it to @borzacchiello :)

@borzacchiello
Copy link
Owner

I started working on it, you can review the progress in the uirefactoring branch. I'm refactoring all the UI elements in a single widget of the side panel. Here it is a demo image:
image

The memory view is the difficult one to port, maybe I must rethink it... 🤔

@borzacchiello
Copy link
Owner

I merged into master the new UI widget, let me know if it works now! I'll leave the issue open for a while.

I refactored and rewrote a lot of code, in particular the memory view is completely new.

Also, now most of the actions can be performed using the buttons on top of the widget (instead of using the right-click menu), including starting the analysis (I will update the documentation in the future).

A screenshot:
image

@0x62797465
Copy link

tysm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants