Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs for variant defaults #626

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Fix docs for variant defaults #626

merged 1 commit into from
Jan 7, 2020

Conversation

tjkirch
Copy link
Contributor

@tjkirch tjkirch commented Jan 3, 2020

Sorry, forgot to do this in #613.

(The main defaults.toml explains the variant overrides, so we don't need to point to all of them all the time.)

@tjkirch tjkirch force-pushed the fix-doc-variant-defaults branch from 3ddee32 to 23ff16f Compare January 6, 2020 19:06
@tjkirch
Copy link
Contributor Author

tjkirch commented Jan 6, 2020

This push fixes conflicts from merging #625.

@tjkirch tjkirch requested review from etungsten and zmrow January 7, 2020 00:26
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍺

@tjkirch tjkirch merged commit d77b875 into develop Jan 7, 2020
@tjkirch tjkirch deleted the fix-doc-variant-defaults branch January 7, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants