-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose public API + make available safely #113
Comments
We fell for missing isolation in #139. |
Given that there are more issues above #139 (cf. #139 (comment)), I'd like to raise the priority of this. Note that the bugs will affect Web Modeler users (design mode). |
So at least the "service footprint" should be fixed. |
We quickly discussed with @barmac different solutions and settled down on two options:
Both approaches would be a major breaking change. I'll investigate further. |
Assigning @nikku to investigate in a time-boxed manner. |
Is your feature request related to a problem? Please describe
Token simulation is a huge extension. Because of that it has a certain set of issues:
Describe the solution you'd like
__exports__
or proper namespacingDescribe alternatives you've considered
Keep what exists, even if it is a little messy.
Additional context
Using didi
__exports__
is properly working since since nikku/didi#13; we could consider to integrate it / use it with bpmn-js-token-simulation.The text was updated successfully, but these errors were encountered: