Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy + Paste and then Undo Collapsed Sub process throws JS Errors #2269

Open
anandcoupa opened this issue Jan 7, 2025 · 3 comments · May be fixed by #2275
Open

Copy + Paste and then Undo Collapsed Sub process throws JS Errors #2269

anandcoupa opened this issue Jan 7, 2025 · 3 comments · May be fixed by #2275
Assignees
@jarekdanielak
Labels
bug Something isn't working ready Ready to be worked on

Comments

@anandcoupa
Copy link

Describe the Bug

Copy Paste and then Undo of Collapsed Sub process throws following JS Errors
unhandled error in event listener TypeError: Cannot read properties of null (reading 'children')
related to MoveConnectionHandler.js

Steps to Reproduce

  1. Create a sample BPMN consisting of a collapsed subprocess
  2. Do a copy paste of the collapsed subprocess
  3. Notice that the paste operation is successful and if you navigate to newly pasted node, you see the underlying elements from the copied subprocess.
  4. Perform undo (cmd+z or ctrl + z)

Actual:

  • Newly pasted collapsed subprocess stays as is, JS error seen in the console

Please find the attached recording

Screen.Recording.2025-01-07.at.4.36.13.PM_compressed.mp4

Expected Behavior

  • No JS errors thrown
  • Undo functionality works as expected.

Environment

  • Browser: Chrome 129
  • OS: MacOS
  • Library version: v17.11.1
@anandcoupa anandcoupa added the bug Something isn't working label Jan 7, 2025
@abdul99ahad
Copy link
Contributor

I can reproduce the error. Moving it to ready

@abdul99ahad abdul99ahad added the ready Ready to be worked on label Jan 7, 2025
@barmac
Copy link
Member

barmac commented Jan 7, 2025

I can reproduce too. This crashes the editor.

@abdul99ahad
Copy link
Contributor

@jarekdanielak to have a look on this.

jarekdanielak added a commit to bpmn-io/diagram-js that referenced this issue Jan 9, 2025
@jarekdanielak
fix(move-connection): null check new parent on revert
89f79d5 
Related to bpmn-io/bpmn-js#2269
jarekdanielak added a commit to bpmn-io/diagram-js that referenced this issue Jan 9, 2025
@jarekdanielak
fix(core/GrahicsFactory): account for removed shapes on updateContain…
7465a5e 
…ments

Related to bpmn-io/bpmn-js#2269
@jarekdanielak jarekdanielak mentioned this issue Jan 9, 2025
Closed
4 tasks
@jarekdanielak jarekdanielak added the in progress Currently worked on label Jan 16, 2025 — with bpmn-io-tasks
@jarekdanielak jarekdanielak removed the ready Ready to be worked on label Jan 16, 2025
@jarekdanielak jarekdanielak linked a pull request Jan 17, 2025 that will close this issue
Draft
4 tasks
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jan 17, 2025
@jarekdanielak jarekdanielak added the in progress Currently worked on label Jan 17, 2025 — with bpmn-io-tasks
@jarekdanielak jarekdanielak removed the needs review Review pending label Jan 17, 2025
@jarekdanielak jarekdanielak added the ready Ready to be worked on label Jan 21, 2025 — with bpmn-io-tasks
@jarekdanielak jarekdanielak removed the in progress Currently worked on label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jarekdanielak jarekdanielak

Labels
bug Something isn't working ready Ready to be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Collapsed subprocess paste & undo bugfix bpmn-io/bpmn-js
4 participants
@jarekdanielak @barmac @abdul99ahad @anandcoupa