Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bpmn-io/dmn-js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 38e707e85c5e9b2610f23c2674e9ea3bdcef210a
Choose a base ref
..
head repository: bpmn-io/dmn-js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 58113182d8aca7867fd4b119a0b2321e3ae62f59
Choose a head ref
Showing with 13 additions and 5 deletions.
  1. +4 −3 package-lock.json
  2. +1 −1 packages/dmn-js-drd/package.json
  3. +8 −1 packages/dmn-js-drd/src/features/label-editing/LabelEditingProvider.js
7 changes: 4 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/dmn-js-drd/package.json
Original file line number Diff line number Diff line change
@@ -27,7 +27,7 @@
],
"dependencies": {
"diagram-js": "^14.3.1",
"diagram-js-direct-editing": "^2.1.2",
"diagram-js-direct-editing": "^3.0.1",
"dmn-js-shared": "^16.1.0",
"inherits-browser": "^0.1.0",
"min-dash": "^4.0.0",
Original file line number Diff line number Diff line change
@@ -113,12 +113,18 @@ LabelEditingProvider.prototype.activate = function(element) {
assign(context, editingBBox);

var options = {};
var style = context.style || {};

// DRG elements
if (is(element, 'dmn:DRGElement')) {
assign(options, {
centerVertically: true
});

assign(style, {
backgroundColor: null,
border: null
});
}

// text annotations
@@ -129,7 +135,8 @@ LabelEditingProvider.prototype.activate = function(element) {
}

assign(context, {
options: options
options: options,
style: style
});

this._canvas.addMarker(element, MARKER_LABEL_HIDDEN);