Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port implicit keyboard binding over to decision editors #920

Closed
nikku opened this issue Nov 8, 2024 · 5 comments
Closed

Port implicit keyboard binding over to decision editors #920

nikku opened this issue Nov 8, 2024 · 5 comments
Assignees
Labels
bug Something isn't working ux

Comments

@nikku
Copy link
Member

nikku commented Nov 8, 2024

Is your feature request related to a problem? Please describe.

With bpmn-io/diagram-js#662 we made sure that keyboard binding works with browser focus, implicitly, and well integrated into the users UX flow. This is not fully integrated in our DMN editors yet, with explicit bind stubs remaining.

Describe the solution you'd like

  • We want to ensure that all editors work in the same way, and that explicit binding is no longer necessary.

Describe alternatives you've considered

None.

Additional context

Child of https://github.com/bpmn-io/internal-docs/issues/1081

@nikku nikku added enhancement New feature or request ux labels Nov 8, 2024
@nikku
Copy link
Member Author

nikku commented Nov 8, 2024

(We could also consider it a bug that this is not properly integrated (yet), hence any follow-up improvement in the same style is not a user land break anymore).

@barmac
Copy link
Member

barmac commented Nov 8, 2024

Since the change was already announced, indeed this looks like an incomplete implementation hence bug.

@jarekdanielak jarekdanielak self-assigned this Nov 13, 2024
@jarekdanielak jarekdanielak added the ready Ready to be worked on label Nov 13, 2024
@jarekdanielak
Copy link
Contributor

Let's consider it a bug then.

@barmac
Copy link
Member

barmac commented Nov 15, 2024

Closed via #921

@jarekdanielak
Copy link
Contributor

I'm closing this issue. We added the new configuration, so the bug is fixed.

I created a follow up issue to bring more UX improvements to DMN editors: #926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ux
Projects
None yet
Development

No branches or pull requests

3 participants