Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTL]: DMN viewer open decision table button missing and elements skewed #927

Open
BrianJVarley opened this issue Dec 12, 2024 · 3 comments
Labels
a11y backlog Queued in backlog bug Something isn't working pr welcome We rely on a community contribution to improve this. ux

Comments

@BrianJVarley
Copy link
Contributor

BrianJVarley commented Dec 12, 2024

Describe the Bug

For right-to-left languages such as Arabic, the document dir attribute is set to dir="rtl"in Angular apps. In most cases elements in the HTML document need to have their CSS adjusted to accommodate this change in direction. For example adjusting padding or mirroring directional icons from right to left.

When using dmn-js Viewer within a web application with document dir="rtl". The blue open decision table button disappears and the labels within the djs-group blocks display outside the bounds of the block.

dir="ltr" (Default)

ltr-view-dmn-table
ltr-dmn-table

dir="rtl"

rtl-view-dmn-table-no-blue-button

Steps to Reproduce

Steps to reproduce the behavior:

  1. Open the demo bpmn.io page & change the document dir attribute to - dir="rtl" using inspect element in dev tools in Chrome.

  2. View a dmn-js chart and notice there is no blue open decision table button on the DMN block. So the user can not view the DMN table. Also notice that the DMN label is outside the bounds of the DMN block.

Screenshot 2024-12-12 at 10 33 46

Expected Behavior

The blue open decision table button is visible on DMN blocks and label is displayed within the block. The user can view the DMN table.

Environment

  • Browser: Chrome 131.0.6778.110 (Official Build) (x86_64)
  • OS: macOS Sonoma 14.7.1
  • Library version: 16.7.0
@BrianJVarley BrianJVarley added the bug Something isn't working label Dec 12, 2024
@barmac
Copy link
Member

barmac commented Dec 12, 2024

Thanks for the report. Would you be interested in contributing a fix?

@barmac barmac added pr welcome We rely on a community contribution to improve this. backlog Queued in backlog labels Dec 12, 2024
@BrianJVarley
Copy link
Contributor Author

@barmac I could have some time in the new year to take a look. Otherwise if you plan to start earlier I could help with the PR review.

@barmac
Copy link
Member

barmac commented Dec 13, 2024

Thanks, we will gladly review your PR in that case!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y backlog Queued in backlog bug Something isn't working pr welcome We rely on a community contribution to improve this. ux
Projects
None yet
Development

No branches or pull requests

2 participants