Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node config options when client doesn't send them #127

Closed
mikesouthron opened this issue Aug 30, 2013 · 4 comments
Closed

node config options when client doesn't send them #127

mikesouthron opened this issue Aug 30, 2013 · 4 comments

Comments

@mikesouthron
Copy link

When the client doesn't send in node config options the http api is sending nothing through to the server.

For example, when the client does not send pubsub#access_model the api server doesn't send anything to the server.

Ideally the API server should fill in any missing config options with a default.

@imaginator
Copy link
Member

Good point. Sensible defaults should be added for any required params.

On 30 August 2013 14:45, mikesouthron [email protected] wrote:

When the client doesn't send in node config options the http api is
sending nothing through to the server.

For example, when the client does not send pubsub#access_model the api
server doesn't send anything to the server.

Ideally the API server should fill in any missing config options with a
default.


Reply to this email directly or view it on GitHubhttps://github.com//issues/127
.

Simon Tennant | buddycloud.com | +49 17 8545 0880 | office hours:
goo.gl/tQgxP

@abmargb
Copy link
Collaborator

abmargb commented Oct 24, 2014

That kind of logic should live in the buddycloud-server instead.

@abmargb abmargb closed this as completed Oct 24, 2014
@imaginator
Copy link
Member

@abmargb does the buddycloud-server do this?

@abmargb
Copy link
Collaborator

abmargb commented Oct 24, 2014

There is a PR in place for this buddycloud/buddycloud-server-java#201, not ready yet though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants