You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 10, 2021. It is now read-only.
I've only recently started using this package for and I must say, I will be using wait for it in my local environment, so it is a convenience to have it bundled.
On the other hand, it should be maybe pointed out in the Readme, however, the Dockerfile is so small, it takes a second to read through - which is always recommended.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hi,
Could you please remove wait-for-it.sh script from Dockerfile and instead
https://github.com/buildkite/docker-puppeteer/blob/master/example/docker-compose.integration-tests.yml#L10
It does not look good when something is downloaded from random place. And in this case it is only needed in tests.
Br,
Markku
The text was updated successfully, but these errors were encountered: