Skip to content
This repository has been archived by the owner on Sep 10, 2021. It is now read-only.

Remove wait-for-it.sh from container #138

Open
RopoMen opened this issue Nov 5, 2020 · 1 comment
Open

Remove wait-for-it.sh from container #138

RopoMen opened this issue Nov 5, 2020 · 1 comment

Comments

@RopoMen
Copy link

RopoMen commented Nov 5, 2020

Hi,

Could you please remove wait-for-it.sh script from Dockerfile and instead

  1. add it in to repository and mount it inside the container before tests
  2. Or download it inside command before tests

https://github.com/buildkite/docker-puppeteer/blob/master/example/docker-compose.integration-tests.yml#L10

It does not look good when something is downloaded from random place. And in this case it is only needed in tests.

Br,
Markku

@b3nk3
Copy link

b3nk3 commented Aug 9, 2021

Hi there,

I've only recently started using this package for and I must say, I will be using wait for it in my local environment, so it is a convenience to have it bundled.

On the other hand, it should be maybe pointed out in the Readme, however, the Dockerfile is so small, it takes a second to read through - which is always recommended.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants