Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to rename attribute data-id. #11

Open
StephanMeijer opened this issue Oct 30, 2024 · 2 comments
Open

Ability to rename attribute data-id. #11

StephanMeijer opened this issue Oct 30, 2024 · 2 comments

Comments

@StephanMeijer
Copy link

StephanMeijer commented Oct 30, 2024

Currently in our application we use an id attribute on every element (except Text node).
We would like to reuse this name in your extension.
Is there any possibility you'd be willing to make the name of the data-id12 attributes configurable?

Footnotes

  1. https://github.com/buttondown/tiptap-footnotes/blob/main/package/src/footnotes/reference.ts#L43

  2. https://github.com/buttondown/tiptap-footnotes/blob/main/package/src/footnotes/footnote.ts#L30

@jmduke
Copy link
Member

jmduke commented Oct 30, 2024

Yup, this seems pretty trivial to do. PR welcome, otherwise @mary-ext is out this week but I can entreat her to tackle it when she gets back!

@StephanMeijer
Copy link
Author

@jmduke Thanks for your fast response! Also reached out to you by email :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants