wasmtime_wasi::bindings compilation error for wasi:cli/exit and wasi:socket/network, missing LinkOptions parameter

[robherley]

Test Case

I have a minimal repro in this repository: https://github.com/robherley/wasmtime-bindgen-repro

Steps to Reproduce

1. Follow the example from wasmtime-wasi crate:
   

   wasmtime/crates/wasi/src/bindings.rs

   Lines 39 to 41 in 58282df

   	//! with: {
   	//! "wasi": wasmtime_wasi::bindings,
   	//! },

2. Attempt to compile.
3. Error, need to cargo expand (see my expanded.rs) or add include_generated_code_from_file: true to the macro.

Expected Results

The generated binding have the correction function signatures.

Actual Results

Versions and Environment

Wasmtime version or commit: 29.0.1

Operating system: macOS 15.1.1

Architecture: arm64

Extra Info

The only affected bindings are:

__with_name0::cli::exit::add_to_linker(linker, get)?;
__with_name0::sockets::network::add_to_linker(linker, get)?;

Which are missing &wasmtime_wasi::bindings::cli::exit::LinkOptions and &wasmtime_wasi::bindings::sockets::network::LinkOptions

[robherley]

I'm guessing this is related to runtime feature-gated options:

• Configure WIT feature gates at runtime & implement wasi-cli exit-with-code #9381

Instead, the generated add_to_linker*** functions take an additional LinkOptions parameter if the world/interface has any unstable features.

[alexcrichton]

Thanks for the report! I think the problem may lie in your original WIT files perhaps? Looking at https://github.com/robherley/wasmtime-bindgen-repro/blob/main/wit/deps/wasi-cli-0.2.3/package.wit I don't see exit-with-code which is a feature-gated API, which means that the two bindgens are starting from different WITs?

[robherley]

👋 @alexcrichton Thanks for following up so fast! It does look like the wit does not match the bindings provided by wasmtime_wasi crate.

But, I resolved my .wit files from wkg:

Which is odd, since the resolved version of wasi-cli-0.2.3 doesn't seem to have exit-with-code?

Even if I run:

wkg get wasi:[email protected]
cat [email protected] | grep exit-with-code

There is no reference to the @unstable(feature = cli-exit-with-code).

Is the version of wasi:cli on the registry incorrect? Or is there something else I'm misunderstanding

[alexcrichton]

I think the issue might like with wkg yeah, there's some subtelties around handling WIT and features which might need some patching. Mind opening an issue over there and cc'ing me?

[robherley]

Totally, I'll close this one out 👍