-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference to tool GitVersion.Tool in toolsettings.cake needs to be updated #1014
Comments
@gep13 I saw your comments on the linked PR - I wanted to make a couple of notes to help others who might stumble on this as much as anything; it seems that the Cake team is generally aware of the breaking changes in GitVersion 6.0, and I suspect you are probably aware of the impact to Recipe from the failing checks and your comments in #1015. The 6.x version of GitVersion contains changes that make it incompatible with Recipe at the current stable version atCake.Recipe.3.1.0, so even pulling in the tool update on an ad hoc basis via See GitTools/GitVersion#2325 and related PR - GitTools/GitVersion#3130 The variables that were removed that matter to the Recipe implementation appear to be -
Based on the changes in the PR to the file
It seems that Recipe could easily enough create a backward compatible implementation [consistent with the existing Recipe implementation] by manipulating some of the variables that are still available (padding/concatenating as necessary)
I think the question becomes whether a deliberately implemented "backward compatible" implementation local to Cake.Recipe is the best path forward? Or do we follow whatever lead that may be set from the upstream Cake tool and the related alias methods/types that may come of cake-build/cake#4453 ? If you have some feedback on approach there, it might be possible to develop a fix in Recipe absent any broader change to the Cake tool. -- For reference & in case anyone else finds this & it helps, this is the diagnostic output of a 6.x tool reference -
|
Reference to GitVersion.Tool 5.12.0 in toolsettings.cake should be updated to 6.0.0
The text was updated successfully, but these errors were encountered: