Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo & split up Scenario Details #593

Open
NQNStudios opened this issue Feb 9, 2025 · 5 comments · May be fixed by #632
Open

Redo & split up Scenario Details #593

NQNStudios opened this issue Feb 9, 2025 · 5 comments · May be fixed by #632
Assignees
Labels
bug dialogxml Affects the dialog system scenedit Affects the scenario editor

Comments

@NQNStudios
Copy link
Collaborator

It should be in a stack so I can see/edit the whole thing with my preferred UI scale.

@NQNStudios NQNStudios added bug dialogxml Affects the dialog system labels Feb 9, 2025
@CelticMinstrel
Copy link
Member

Alternative idea: we could move some of the options along the bottom to a new "Advanced Scenario Details" dialog. Campaign ID is definitely advanced, and for backgrounds, they're in the advanced section for town details. They aren't in the advanced section for outdoor details, but that's only because there is no advanced section there. I'm not sure whether "Special on Start" should be considered advanced. Everything above that is definitely not advanced.

@NQNStudios NQNStudios added the scenedit Affects the scenario editor label Feb 9, 2025
@NQNStudios NQNStudios self-assigned this Feb 15, 2025
@NQNStudios
Copy link
Collaborator Author

@CelticMinstrel If this isn't one of the dialogs you're working on, I can do it.

While I'm at it, I want to add Scenario Title and Author as fields to the basic scenario details, and remove the text that says there's no easy way to change those later.

@CelticMinstrel
Copy link
Member

Sounds good to me!

@NQNStudios
Copy link
Collaborator Author

NQNStudios commented Feb 17, 2025

There are more fields in scenario details/XML that I think could be done away with.

field Can be edited later Is shown to players should we get rid of it
Title no yes no
Author no no yes
Contact info yes no yes

I think make-scenario1 should prompt you for a title, a tagline, and your name/handle. Optionally, maybe, contact info.

It should put "by {name/handle}, contact: {contact}" in credits part 1, and the tagline in credits part 2. (Note that then the designer can edit that formatting manually later).

We can cut contact info from scenario details to save space.

@NQNStudios NQNStudios changed the title edit-scenario-details.xml is too tall Redo & split up Scenario Details Feb 17, 2025
@CelticMinstrel
Copy link
Member

CelticMinstrel commented Feb 17, 2025

I dunno, adding all the contact info into the create scenario dialog seems a bit questionable. Someone starting a new scenario probably wants to get started as soon as possible, so I think asking them for more than the absolute minimum is probably not a good idea. I'd almost even suggest removing author from there, though if it's just that then I don't think it's a problem.

That said, splitting all the contact info into a separate dialog isn't a bad idea. I'm only questioning making it part of the create flow.

@NQNStudios NQNStudios linked a pull request Feb 18, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dialogxml Affects the dialog system scenedit Affects the scenario editor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants