Some notes:

• The inability to edit the scenario title later on is a regression from the original game, which stored title and credits as the first four scenario strings (title, who wrote x2, and contact info).
• There was no author string in the original game. I added that at some point. I don't remember why, but if we're deprecating it I imagine we should check.
• I couldn't find any place in the original source that used the contact_info value (there called scen_strs[3] if I'm not mistaken)… which makes me wonder how JV originally intended it to be used in the first place.

I guess I don't really get it. You're taking the author and contact info and stuffing them into "who wrote 1" in a specific format. If you want them in a specific format, why stuff them into a freeform field? I guess it does let the author decide to use a different format if they want, but what's the benefit of that?

I don't remember where the Who Wrote strings were displayed in legacy BoE (if at all), so it's hard to say if this change to their "identity" makes sense. Aren't they shown in the scenario select dialog?

They're shown in the scenario selection dialog, yes. And the reason I prefer suggesting the format they should take, as opposed to actually forcing it, is that forcing it would require messing with the dialogxml for the scenario picker, and changing the scenario picker's code, too. I'd rather not take the risk of introducing new bugs doing that for little gain.

Oh, and it keeps legacy scenarios displaying Who Wrote1 and Who Wrote 2 the way they intended.

It is a little wonky. I'll rework it.

@CelticMinstrel reworked, with the PR description updated to explain the changes.

I forgot to cherry-pick the menubar item commits

There we go.