Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle line feed in DMN element name #4390

Closed
1 of 2 tasks
barmac opened this issue Jun 20, 2024 · 4 comments
Closed
1 of 2 tasks

Correctly handle line feed in DMN element name #4390

barmac opened this issue Jun 20, 2024 · 4 comments
Assignees
Labels
Milestone

Comments

@barmac
Copy link
Collaborator

barmac commented Jun 20, 2024

What should we do?

image

Why should we do it?

Ensure good UX.

Reported via https://camunda.slack.com/archives/C0693F1NFK5/p1718869256259379

@barmac barmac added DMN ux backlog Queued in backlog labels Jun 20, 2024
@nikku nikku added ready Ready to be worked on and removed backlog Queued in backlog labels Jul 3, 2024
@nikku
Copy link
Member

nikku commented Jul 3, 2024

Assigned @jarekdanielak as we fixed the biggest issue in this bucket via bpmn-io/dmn-js-properties-panel#95; to consider to close this issue, or handle missing aspects as a follow-up.

If this is "fixed upstream", let's move it into the column .

@jarekdanielak
Copy link
Contributor

First part of the issue was fixed upstream by bpmn-io/dmn-js-properties-panel#95.

Second part is more tricky and requires more discussion as described in bpmn-io/dmn-js#884.

Moving this issue back to backlog until the underlaying issue is further discussed.

@jarekdanielak jarekdanielak added backlog Queued in backlog and removed ready Ready to be worked on labels Jul 30, 2024
@nikku
Copy link
Member

nikku commented Aug 21, 2024

@jarekdanielak I don't see how "overlapping with the icon" should block us from progressing on this issue. Overlapping with the icon is a standard behavior in our tools. You have the means (manual newlines) in place to prevent it.

My suggestion is to close this issue (if newline is now accounted for in the properties panel) and leave the other issue as a follow-up.

@jarekdanielak
Copy link
Contributor

Closing this one.

bpmn-io/dmn-js#884 has some more discussion about UI behavior is case of overlap.

@bpmn-io-tasks bpmn-io-tasks bot removed the backlog Queued in backlog label Aug 21, 2024
@github-actions github-actions bot added this to the M80 milestone Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants