Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add microsoft edge #45

Open
z3nitsu opened this issue Nov 8, 2020 · 10 comments
Open

Please add microsoft edge #45

z3nitsu opened this issue Nov 8, 2020 · 10 comments

Comments

@z3nitsu
Copy link

z3nitsu commented Nov 8, 2020

You have a great repo. Can please add Microsoft edge browser also

@moriel5
Copy link
Contributor

moriel5 commented Nov 10, 2020

I'm already working on it, I'm just having issues getting the build process to complete.

@z3nitsu
Copy link
Author

z3nitsu commented Nov 11, 2020

I'm already working on it, I'm just having issues getting the build process to complete.

thnx

@moriel5
Copy link
Contributor

moriel5 commented Dec 30, 2020

Unfortunately, I am stuck, since I am pretty sure that I got everything right, however the build just fails in the middle, and I am unable to find out via STrace what is the issue.
If anyone can help, I'm all ears.

@ghost
Copy link

ghost commented Jan 21, 2021

Unfortunately, I am stuck, since I am pretty sure that I got everything right, however the build just fails in the middle, and I am unable to find out via STrace what is the issue.
If anyone can help, I'm all ears.

Someone packaged it in the past
https://github.com/prateekmedia/Solus-3rdParty
Try asking him if u can :)

@moriel5
Copy link
Contributor

moriel5 commented Jan 24, 2021

Unfortunately, I am stuck, since I am pretty sure that I got everything right, however the build just fails in the middle, and I am unable to find out via STrace what is the issue.
If anyone can help, I'm all ears.

Someone packaged it in the past
https://github.com/prateekmedia/Solus-3rdParty
Try asking him if u can :)

Thanks, however it would appear that his package conversion places the folder into /opt, which is precisely what I am trying to avoid, since I am trying to keep in line as possible with the official Solus paradigm, which means putting it into /usr/lib64.

Though the official Vivaldi package stores the folder, for whatever reason, in /usr/share, so I am going to ask about that, since Firefox and other browsers (such as GNOME Web/Epiphany) are stored in /usr/lib64.

Manually placing Edge in /usr/lib64 works as expected, without any issues (though you need to change the symlink in /usr/bin to point there, as well as add the icons to /usr/share/icons, though those should be obvious). The odd thing is that during the packaging, it simply fails to find the extracted files with no apparent reason, which is why I am stuck.

@moriel5
Copy link
Contributor

moriel5 commented Apr 12, 2021

@prateekmedia I realize you no longer package Solus packages, but would you have an idea as to why I am unable to package Microsoft Edge via SolBuild?

@prateekmedia
Copy link

prateekmedia commented Apr 13, 2021

@prateekmedia I realize you no longer package Solus packages, but would you have an idea as to why I am unable to package Microsoft Edge via SolBuild?

What I did to package it was to copy an application's 3rd party solus repo file and tweaked some parameters here and there.

You could try copying brave or chrome's solbuild file and then tweak the url, sha1 and other parameters, also don't forget to also copy its icons froms edge folder to pixmaps as microsoft edge is new and no icon packs have its icon.

It was easy from 3rd party repo cause it was just converting .deb to .eopkg but I don't know how SolBuild works, also note that only I have stopped maintaining it but you can also maintain it and it's very easy, just change the url and sha1 and follow the command in readme.

@prateekmedia
Copy link

If you really want to put edge in /usr/lib64 you can tweak some thing's in my python script of edge. It is easy but I didn't think your package will be accepted officially so why do you want to place it in that folder only?

Also note that edge in now in flatpak beta, so you don't have to maintain it to use the latest version, if you want an containerized package.

@moriel5
Copy link
Contributor

moriel5 commented Apr 13, 2021

@prateekmedia Thanks for the insight.

SolBuild is actually pretty easy to work with and you can use it to convert .deb or .rpm to .eopkg, I recommend you to take a look at it.

Regarding the Python script, I do not think that will help, seeing that SolBuild builds the package in a virtualized environment.

And I am quite aware that this has no chance of making it into the official repo, unless Microsoft allows it officially, this is just as official as your old packages.

I do not want to rely on Flatpak on a system that due not require it in the first place (I'd rather use Flatpak instead, rather than in addition), since I do not wish to install major parts of the system, such as the entire GTK runtime collection, twice, just for a few apps.

@moriel5
Copy link
Contributor

moriel5 commented Apr 13, 2021

@prateekmedia Thanks, I'm surprised I had forgotten about Brave, I'll look into that.

I tried basing my package.yml off that of Vivaldi, however as mentioned, for whatever reason it is stored in it's own folder under /usr/shared (and yes, the official package converts the .deb to a . eopkg).

Update: The official .eopkg for Brave also stores it in/usr/share.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants