Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to Controller log out behavior #1449

Open
7 tasks
clicksave opened this issue Mar 3, 2025 · 0 comments
Open
7 tasks

Fixes to Controller log out behavior #1449

clicksave opened this issue Mar 3, 2025 · 0 comments

Comments

@clicksave
Copy link

clicksave commented Mar 3, 2025

https://www.loom.com/share/2448cf989db348028caa70039cfa8968?sid=c2884b5f-f6c4-4a48-bbba-fd273c8a04fe

Check out the attached video for an example of the following issues.

Behavior

  • Players do not appear logged out after logging out of the controller

  • Controller does not close (secondary profile page stays open)

  • Players still appear as logged in in the app header

  • Close button does not close the controller profile

  • Settings appears as a separate modal on top of the profile modal and while logging out closes the settings modal it does not close the profile modal. Similar issue to the one above


UI Improvements

  • horizontal padding for the close button is larger than the bottom padding. feels wrong

Change from

Image

to ->

Image
  • We're not seeing the border top of the footer either. not a huge deal until we have content below the fold but would be nice to see

  • Update the menu to match the log out menu in figma

Image

https://www.figma.com/design/OSbzNkyR9UYV4Erz9oF9JJ/%F0%9F%95%B9%EF%B8%8F-Controller?node-id=9270-37252&t=liZFbENMBZ0hztU1-1

  • Show username and address details in the footer

  • If we're going to render the settings page as a separate modal we should remove the translucent background layer over the app as its already present from the profile page. The page shouldn't get darker when the settings page appears.

@clicksave clicksave changed the title Fixes to log out pattern. Fixes to log out behavior Mar 3, 2025
@clicksave clicksave changed the title Fixes to log out behavior Fixes to Controller log out behavior Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant