Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix exp/teatest tests on windows #389

Open
andreynering opened this issue Feb 27, 2025 · 1 comment
Open

ci: fix exp/teatest tests on windows #389

andreynering opened this issue Feb 27, 2025 · 1 comment

Comments

@andreynering
Copy link
Member

We did a fix recently about golden files on Windows: #365

That fixed many tests on Windows, but on this repository two started failing. We need to figure it out if there is a better way this the below to handle \r\n golden files checkout by Git on Windows.

x/exp/golden/golden.go

Lines 78 to 80 in 59292a3

if runtime.GOOS == "windows" {
return strings.ReplaceAll(str, "\r\n", "\n")
}

Perhaps we can remove the fix done on #365 and replace it by a .gitattributes file instructing Git to preserve *.golden files as is? We'd need to do this on all relevant repositories, though, not only on this one.

@aymanbagabas
Copy link
Member

Perhaps we can remove the fix done on #365 and replace it by a .gitattributes file instructing Git to preserve *.golden files as is? We'd need to do this on all relevant repositories, though, not only on this one.

I like this idea, we can trea *.golden files as binary files. Then Git would leave them as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants