You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We did a fix recently about golden files on Windows: #365
That fixed many tests on Windows, but on this repository two started failing. We need to figure it out if there is a better way this the below to handle \r\n golden files checkout by Git on Windows.
Perhaps we can remove the fix done on #365 and replace it by a .gitattributes file instructing Git to preserve *.golden files as is? We'd need to do this on all relevant repositories, though, not only on this one.
The text was updated successfully, but these errors were encountered:
Perhaps we can remove the fix done on #365 and replace it by a .gitattributes file instructing Git to preserve *.golden files as is? We'd need to do this on all relevant repositories, though, not only on this one.
I like this idea, we can trea *.golden files as binary files. Then Git would leave them as is.
We did a fix recently about golden files on Windows: #365
That fixed many tests on Windows, but on this repository two started failing. We need to figure it out if there is a better way this the below to handle
\r\n
golden files checkout by Git on Windows.x/exp/golden/golden.go
Lines 78 to 80 in 59292a3
Perhaps we can remove the fix done on #365 and replace it by a
.gitattributes
file instructing Git to preserve*.golden
files as is? We'd need to do this on all relevant repositories, though, not only on this one.The text was updated successfully, but these errors were encountered: