Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wonder if html report bug is intentional #2

Open
seblm opened this issue May 23, 2023 · 0 comments
Open

Wonder if html report bug is intentional #2

seblm opened this issue May 23, 2023 · 0 comments

Comments

@seblm
Copy link

seblm commented May 23, 2023

In the java version of the html report it seems that there is a bug where Total expenses are not correct:

            System.out.println("<p>Total expenses: " + mealExpenses + "</p>");

I would rather wrote:

-           System.out.println("<p>Total expenses: " + mealExpenses + "</p>");
+           System.out.println("<p>Total expenses: " + total + "</p>");

Is this intentional? Other languages like scala do not have this bug. I think it could be a good exercice to leave it as is and notify people that there is also a bug to find and fix. But in this case, it should be present in every language of this repository.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant