-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Optional output of grype and prometheus debug statements #388
Comments
Thanks for your detailed report. Yes, this would be a very good enhancement, please add a new flag as well to control the verbosity of grype. Thanks for your work! |
This issue is stale because it has been open 90 days with no activity. Remove stale label with |
This issue is stale because it has been open 90 days with no activity. Remove stale label with |
This issue is stale because it has been open 90 days with no activity. Remove stale label with |
This issue is stale because it has been open 90 days with no activity. Remove stale label with |
While I was debugging an issue, I decided to enable the logging package in the grype module so that I could see if my sbom was actually being processed (I received no results initially, but resolved the issue -- see #386 for details). I wondered if you wanted me to submit a PR with this modification. I fed the
verbosity
argument into the grype logging module in order to do this. If this logging feature is desired, perhaps it would be better to have a new argument called--grype-verbosity
or something similar because it is extremely verbose, and the logging may not be desired in most cases.Let me know if:
--grype-verbosity
or similar so that there is not a flood of output in the standard vulnerability-operator use caseAnother thing is that I would like to attempt is to enable logging from the prometheus metrics module. I feel this will be useful to see when/if the metrics are being scraped and whatever other debug output the prometheus endpoint code can provide. Let me know if you think this would be something that you would want in the main code base. I can't guarantee this feature at this moment because I haven't looked into how easy or hard it is. The grype logging was non-trivial because of I've been learning Go along the way, and the Grype logging module makes you pass some "extra stuff" which turns out to be useless but necessary to have things operate properly.
BTW thanks for this project, it has filled a use case that I had initially started writing from scratch, but your features check a lot of boxes for what I want to accomplish, and after some tweaking it works beautifully. Also it has helped me to learn Go as I had to figure out why certain things were going wrong along the way to getting everything working :)
The text was updated successfully, but these errors were encountered: