fixed issue #1755:video starts from where it was left #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The progress of the video is saved on localstorage and retrieved from the storage each time the page mounts again |
|
It's better to get that data from db only. Sync across devices and all. Also, makes it less complicated |
|
Hi, i may be wrong but when page re mounts again it starts from the very
beginning may be retrieving from db is slow or not pushing to db at all
should I look into it
…On Fri, 28 Feb, 2025, 1:02 am Sargam, ***@***.***> wrote:
It's better to get that data from db only. Sync across devices and all.
Also, makes it less complicated
—
Reply to this email directly, view it on GitHub
<#1761 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BHSQIDGJDEDH36HTMLMDZD32R5R4HAVCNFSM6AAAAABXUQHMRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBYHEZDAMJXGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: devsargam]*devsargam* left a comment (code100x/cms#1761)
<#1761 (comment)>
It's better to get that data from db only. Sync across devices and all.
Also, makes it less complicated
—
Reply to this email directly, view it on GitHub
<#1761 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BHSQIDGJDEDH36HTMLMDZD32R5R4HAVCNFSM6AAAAABXUQHMRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBYHEZDAMJXGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Fixes:
Resolves #1755
Checklist before requesting a review