Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash on get_absolute_media_url #70

Open
Chadys opened this issue Sep 6, 2024 · 0 comments
Open

crash on get_absolute_media_url #70

Chadys opened this issue Sep 6, 2024 · 0 comments

Comments

@Chadys
Copy link
Contributor

Chadys commented Sep 6, 2024

Hello,
get_absolute_media_url is used with utils.get_absolute_media_url(self.get_site()), but sometimes get_sitereturns None and so the website crash.
It happen when the page is not routable (not sure yet when that is, in my case it seems to be a complex issue around the usage of wagtail-localize).
I think get_absolute_media_url should check for None values (I can make the PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant