Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various random CI image test failures #1456

Open
kkoreilly opened this issue Jan 26, 2025 · 1 comment
Open

Fix various random CI image test failures #1456

kkoreilly opened this issue Jan 26, 2025 · 1 comment
Assignees
@kkoreilly
Labels
bug Something isn't working correctly confirmed This bug has been confirmed
Milestone
v0.4

Comments

@kkoreilly
Copy link
Member

kkoreilly commented Jan 26, 2025 •
edited
Loading

Describe the bug

Almost everything is working with #1347, but there are a few tests that randomly fail, marked with TODO(#1456).

For tests like TestSnackbarTime, we probably just want to change the times so they are farther apart and there is less chance of failure.

How to reproduce

Remove the t.Skips on the tests with the aforementioned TODO and then run CI.

Example code



Relevant output




Platform


macOS

      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @kkoreilly
kkoreilly




            added
      

  bug

  Something isn't working correctly

      

  confirmed

  This bug has been confirmed

  labels


      Jan 26, 2025

    

  



    


    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this to Todo
  in Bugs


      Jan 26, 2025

    

  



    

    

      
    

    


      

          @kkoreilly
kkoreilly




          added this to the   v0.4 milestone


      Jan 26, 2025

    

  



    

    

      
    

    


      

          @kkoreilly
kkoreilly




              self-assigned this


      Jan 26, 2025

    

  



  


  
    
  
  

    
  kkoreilly 

      added a commit
      that referenced
      this issue

    
      Jan 26, 2025
    
    

      


  

    

      


  

      
        @kkoreilly
  





      

        
          testing: skip some tests for now (see #1456)
        


      


      

          

    
    
    

  

      


      

          

    
    
    

  

  

    
  



      


      
      

        
          68fa66f
        
      

    

  




    

  




  


  
    
  
  

    
  kkoreilly 

      added a commit
      that referenced
      this issue

    
      Jan 26, 2025
    
    

      


  

    

      


  

      
        @kkoreilly
  





      

        
          testing: temporarily increase imagex.Assert tolerance to 5 until we f…
        

          
            
          

      


      

          

    
    
    

  

      


      

          

    
    
    

  

  

    
  



      


      
      

        
          609823b
        
      

    

  

    

      
…ix rendering inconsistencies (#1456)

    




    

  









      

  
      



  

  @kkoreilly





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  Author


  


  

    

  





      


        


  
    

      
          
I had to temporarily increase the imagex.Assert tolerance to 5 for this; once #1457 is done, if this issue is still not resolved, we should debug further.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
          


  
    
  
  

    
  kkoreilly 

      added a commit
      that referenced
      this issue

    
      Jan 26, 2025
    
    

      


  

    

      


  

      
        @kkoreilly
  





      

        
          skip TestDialogMessage for now (#1456)
        


      


      

          

    
    
    

  

      


      

          

    
    
    

  

  

    
  



      


      
      

        
          2096650
        
      

    

  




    

  




  


  
    
  
  

    
  kkoreilly 

      added a commit
      that referenced
      this issue

    
      Jan 26, 2025
    
    

      


  

    

      


  

      
        @kkoreilly
  





      

        
          testing: increase temporary tolerance to 10 (#1456); temp force update
        


      


      

          

    
    
    

  

      


      

          

    
    
    

  

  

    
  



      


      
      

        
          36e9a0e
        
      

    

  




    

  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                    




    

  


      
  

    Assignees
  



        

      

        

  
      @kkoreilly
  
    kkoreilly
    

      








      


  


  

    Labels
  



    

      

    bug

  Something isn't working correctly
  

    confirmed

  This bug has been confirmed








      

  

    

        

    Projects
  


        




        
  

    

      
          
        Bugs
        
    

    

      

            
    Status: Todo

              
      

    

    

  







  



      


  

    
  

    Milestone
  


      
    
  
    v0.4
  





    
      
          


  

    
      

        
    

    Development
  




          
    
No branches or pull requests







    
  




      

    

  
      

  

    

      1 participant
    

    

        
          @kkoreilly